Enforces order of transmitted messages #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This involved an absolutely massive refactor that completely changed the interface. Things should be much more robust now.
|
@IvanMalison thank you for this contribution! I'll check it when I'll have some spare time. |
|
A better solution to the problem that this is trying to solve might be to use channel buffering. The question then is what to do when a receiver channel buffer is full |
|
@grafov Any chance we can get this merged? |
|
I just hit that. I can confirm it's happening. Either this should be fixed, or documentation need to be very clear about this fact. |
|
this should be merged. |
|
I agree with you but I forget about this project :( Sure, as it has stars and people try use it, let fix it. |
|
@IvanMalison many thanks for making this code usable! :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This involved an absolutely massive refactor that completely changed the
interface. Things should be much more robust now.
Fixes #8 and #9