Client go containerregistry #71
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a slice of work to deprecate voucher's internal
docker/package, replacing it with the awesome https://github.com/google/go-containerregistry.This chunk is focussed on isolating the bits from
docker/we'll need to keep (AFAICT: the bit that extracts GCP projects from GCR urls?) and updating the./cmd/voucher_clientimplementation to use go-containerregistry. As part of this, I also trimmed down thevoucher_clientimplementation to DRY.I want to use go-containerregistry because of #47 - I think voucher should become aware of multi-arch images/manifest lists, and I think switching to go-containerregistry's implementation is a better direction than adding to voucher's custom registry codez.