Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in documentation of __param_ for prometheus.scrape #5995

Closed
Gusser93 opened this issue Dec 18, 2023 · 0 comments · Fixed by #6009
Closed

Error in documentation of __param_ for prometheus.scrape #5995

Gusser93 opened this issue Dec 18, 2023 · 0 comments · Fixed by #6009
Labels
bug Something isn't working frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.

Comments

@Gusser93
Copy link

What's wrong?

The documentations states:

__param__ is a prefix for labels that provide URL parameters used to scrape a target.

It seems correct would be

__param_ is a prefix for labels that provide URL parameters used to scrape a target.

Note the single _ at the end instead of two.

Steps to reproduce

Try to write a config using __param__foo, go to localhost:12345 and look at the "scraper → Debug info / target" block. There the parameter foo has an unintended leading _ resulting in _foo.

System information

Ubuntu 20.04.6 LTS x86_64 5.4.0-167-generic

Software version

Grafana Agent v0.38.1

Configuration

prometheus.scrape "foo" {
  targets = [
    {"__address__" = "localhost:123456789", "instance" = "bar", "__param__foo" = "bar"},
  ]
  forward_to = [
    prometheus.remote_write.local.receiver,
  ]
}

Logs

No response

@Gusser93 Gusser93 added the bug Something isn't working label Dec 18, 2023
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant