Prefer OS Specific Paths

[catuhana]

Closes #470

This could be done in a better way, but for the sake of simplicity and not changing things too much, I preferred this way.

[cla-bot]

We require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please send a signing request to cla-requests@gdlauncher.com and add your github handle to contributors list.

[catuhana]

This should also fix #468 I think

[theRookieCoder]

I was reviewing this, and I remembered that I also wanted to use the platform's recommended cache directory for downloading and extracting modpacks. I was looking up the dirs documentation, and discovered that it's actually recommended to use directories, which is higher level than dirs.

[catuhana]

I was reviewing this, and I remembered that I also wanted to use the platform's recommended cache directory for downloading and extracting modpacks. I was looking up the dirs documentation, and discovered that it's actually recommended to use directories, which is higher level than dirs.

Alrighty, will do both soon today.

[catuhana]

Are we sure we don't want to use /Library/Application Support/ for ferium on macOS? Having to use ~/.config for macOS kinda defeats the point of using directories, e.g. we have to do this:

#[cfg(target_os = "macos")]
{
    crate::BASE_DIRS
        .home_dir()
        .join(".config")
        .join("ferium")
        .join("config.json")
}

#[cfg(not(target_os = "macos"))]
{
    crate::PROJECT_DIRS.config_dir().join("config.json")
}

meanwhile we can only use the last block?

Also, since we'll use system cache paths now, should I rename the old

~/.config/ferium/.cache
                 ^^^^^^

and

~/.config/ferium/.tmp
                 ^^^^

to <SYSTEM_CACHE_DIR>/ferium/downloaded and <SYSTEM_CACHE_DIR>/ferium/extracted respectively? It sounds not intuitive to keep them named as is.

[theRookieCoder]

Are we sure we don't want to use /Library/Application Support/ for ferium on macOS?

Yeah I would really prefer using the standard *NIX ~/.config on macOS.

kinda defeats the point of using directories

Outside of Windows, one benefit of using this method is that we're now using XDG user directories on Linux.

to <SYSTEM_CACHE_DIR>/ferium/downloaded and <SYSTEM_CACHE_DIR>/ferium/extracted respectively?

Yep that would be great!

[cla-bot]

We require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please send a signing request to cla-requests@gdlauncher.com and add your github handle to contributors list.

[cla-bot]

We require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please send a signing request to cla-requests@gdlauncher.com and add your github handle to contributors list.

[catuhana]

Ready for review.

[catuhana]

Reminder to self: add to changelog after approval.

[cla-bot]

We require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please send a signing request to cla-requests@gdlauncher.com and add your github handle to contributors list.

[theRookieCoder]

I used %APPDATA% instead of %LOCALAPPDATA% because the latter is meant for large or temporary files, persistent configs should be in %APPDATA%.

[cla-bot]

We require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please send a signing request to cla-requests@gdlauncher.com and add your github handle to contributors list.

[cla-bot]

We require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please send a signing request to cla-requests@gdlauncher.com and add your github handle to contributors list.

[theRookieCoder]

Thank you for the contribution!

[catuhana]

Seems like 9e04587 doesn't compile, just FYI in case its unnoticed.