Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PackagePath Parsing for Pointer Types in type2.go #105

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Fix PackagePath Parsing for Pointer Types in type2.go #105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions type2.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,14 @@ func (p *typeParser) parseType(address uint64) (*GoType, error) {
count += c

if uc.Mcount != 0 {

// When typ.Kind is reflect.Ptr, PackagePath is not parsed, so read
// PkgPath from uncommonType as typ's PackagePath
if typ.Kind == reflect.Ptr && len(typ.PackagePath) == 0 {
// Resolve package path.
typ.PackagePath, _ = p.resolveName(uint64(uc.PkgPath), 0)
}

// We have some methods that needs to be parsed. From source code
// comments the Moff attribute is the offset from the beginning of
// the uncommon data structure to where the array of methods start.
Expand Down
Loading