refactor: removes debug/macho and GetFile #103
Conversation
Zxilly
changed the title
|
@TcM1911 Can you take a look at this patch? |
| @@ -181,16 +184,16 @@ func (f *GoFile) initPackages() error { | |||
| return f.initPackagesError | |||
| } | |||
|
|
|||
| // GetFile returns the raw file opened by the library. | |||
| func (f *GoFile) GetFile() *os.File { | |||
There was a problem hiding this comment.
This is removing an exported method which likely will break some stuff downstream. I know it's not a 1.0 version yet so breakage is not guaranteed but I like to avoid it as much as possible.
There was a problem hiding this comment.
Since we didn't hold a *os.File right now, there's no way to keep providing this API.
There was a problem hiding this comment.
https://github.com/search?q=lang%3AGo+github.com%2Fgoretk%2Fgore&type=code
Additionally, I performed a search in GitHub and no repositories seem to be calling this API except for my project https://github.com/Zxilly/go-size-analyzer.
Closes: #101
Closes: #102