Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation to all DatastoreRepositoryTest tests. #203

Open
wants to merge 1 commit into
base: datastoredocs
Choose a base branch
from

Conversation

MagoDelBlocco
Copy link
Contributor

Added explanations for all the tests.

Also removed unnecessary throws clause from the tests as well, since it was a leftover from another version of the tests.

@MagoDelBlocco MagoDelBlocco self-assigned this Sep 23, 2020
@MagoDelBlocco MagoDelBlocco changed the base branch from master to datastoredocs September 23, 2020 17:37
@MagoDelBlocco MagoDelBlocco added documentation Improvements or additions to documentation P1 labels Sep 24, 2020
Copy link
Collaborator

@samuelsogbesan samuelsogbesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -92,10 +110,10 @@ public void testValidDeletion() throws IOException, InterruptedException {
}

/**
* Tests the behaviour of add/update/get/delete requests on null data.
* Tests the behavior of all DatastoreRepository methods on null data. All should return NPE.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a brit, this hurt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation P1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants