Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update property usWidthClass property for Condensed fonts #131

Merged
merged 1 commit into from
Jan 9, 2025
Merged

update property usWidthClass property for Condensed fonts #131

merged 1 commit into from
Jan 9, 2025
+16 −17

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Dec 27, 2024

Fix: #130
Related: typst/typst#2098

@drupol drupol mentioned this pull request Dec 27, 2024
Merged
13 tasks
drupol added a commit to drupol/nixpkgs that referenced this pull request Dec 27, 2024
@drupol
roboto: patch RobotoCondensed font to fix usWidthClass
96eef3f 
See googlefonts/roboto-3-classic#130
Upstream patch: googlefonts/roboto-3-classic#131
drupol added a commit to drupol/cv that referenced this pull request Dec 27, 2024
@drupol
cv: use text.stretch - fix Roboto font
fb8ef8a 
See googlefonts/roboto-3-classic#131 and NixOS/nixpkgs#368615
@EpicEricEE
Copy link

Might also need to adjust the openTypeOS2WidthClass entries in the sources/RobotoCondensed-*.ufo/fontinfo.plist files as they are also set to 5 instead of 3.

@drupol drupol force-pushed the update-condensed-usWidthClass branch from 952219e to d6893e7 Compare December 27, 2024 21:29
@drupol
Copy link
Contributor Author

drupol commented Dec 27, 2024

Updated, thanks for letting me know !

@drupol
Copy link
Contributor Author

drupol commented Jan 1, 2025

@m4rc1e Hi ! Do you think you could have a look at this PR ?

@m4rc1e
Copy link
Collaborator

m4rc1e commented Jan 9, 2025

Hey @drupol. Sorry for my late reply, was enjoying the xmas break.

PR looks great. Let's see what the CI says.

@drupol
Copy link
Contributor Author

drupol commented Jan 9, 2025

Excellent, thank you! Happy merry Christmas and New Year to you !

@m4rc1e
Copy link
Collaborator

m4rc1e commented Jan 9, 2025

@drupol thanks! sigh, I'll start fixing the ci.

@m4rc1e m4rc1e mentioned this pull request Jan 9, 2025
Merged
@m4rc1e
Copy link
Collaborator

m4rc1e commented Jan 9, 2025

Apologies for the delay. Fixing ci pipelines suck the life out of you.

Would you mind rebasing this pr so the tests will run correctly?

@drupol drupol force-pushed the update-condensed-usWidthClass branch from d6893e7 to 33601fb Compare January 9, 2025 15:15
@drupol
Copy link
Contributor Author

drupol commented Jan 9, 2025

Done.

m4rc1e
m4rc1e approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@m4rc1e m4rc1e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work. Thank you very much!

I'll cut a new release some time next week.

We just pushed the variable fonts to Google Fonts yesterday (v3.009) and so far no complaints.

@m4rc1e m4rc1e merged commit 498acd7 into googlefonts:main Jan 9, 2025
2 checks passed
@drupol drupol deleted the update-condensed-usWidthClass branch January 9, 2025 15:48
@drupol
Copy link
Contributor Author

drupol commented Jan 9, 2025

Excellent, do you know when a new release is going to be published?

@m4rc1e
Copy link
Collaborator

m4rc1e commented Jan 9, 2025

I think I'll cut a new release once I merge #132 and can confirm it'll be server on Google Fonts.

@drupol
Copy link
Contributor Author

drupol commented Jan 9, 2025

Okay. I subscribed to the thread so that once it's done, I'll update nixpkgs and revert my patch at NixOS/nixpkgs#368615

@drupol
Copy link
Contributor Author

drupol commented Jan 24, 2025

@m4rc1e Any update status on this? Looks like #132 is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4rc1e m4rc1e m4rc1e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong width class for Roboto Condensed
3 participants
@drupol @EpicEricEE @m4rc1e