This repository was archived by the owner on Mar 13, 2018. It is now read-only.
Remove isPrimary from tap event #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there is no reason to limit this to the primary
|
Before this PR can be merged, please sign the CLA. See the CONTRIBUTING guide. |
|
already did it with my gmail last time... i tried it again now, may you check if it worked? |
|
Thanks for signing the CLA! |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no point in limiting the tap to the primary pointer.
Use case: imagine the primary pointer is being busy doing a drag & drop operation while another pointer wants to tap somewhere.