Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a py.typed file for submodule #407

Closed
crwilcox opened this issue Oct 12, 2021 · 3 comments
Closed

Add a py.typed file for submodule #407

crwilcox opened this issue Oct 12, 2021 · 3 comments
Labels
api: bigquery Issues related to the googleapis/python-bigquery-pandas API. type: process A process-related concern. May include testing, release, or the like.

Comments

@crwilcox
Copy link

To be in accordance with PEP 561 we should add a py.typed file to pandas_gbq/py.typed

The file can be empty but does need to be present for some type checkers.
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-pandas API. label Oct 12, 2021
@crwilcox
Copy link
Author

Do note, you may need to run mypy, pyright, pytype against our samples before merging. It will ensure that we aren't exposing users to failing type checks.

Ideally we would add this to CI as well, to avoid future breakage.

@meredithslota meredithslota added the type: process A process-related concern. May include testing, release, or the like. label Oct 14, 2021
@tswast
Copy link
Collaborator

tswast commented Oct 26, 2021

Blocked by: #325 -- We don't currently publish any type annotations.

@tswast tswast mentioned this issue Jan 18, 2022
Merged
4 tasks
@tswast
Copy link
Collaborator

tswast commented Jun 27, 2022

Closing as a duplicate of #325

@tswast tswast closed this as completed Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-pandas API. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tswast @crwilcox @meredithslota