-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg: avoid log.Fatal calls #5700
Conversation
0b3c716
to
35898d9
Compare
35898d9
to
c2f73fb
Compare
@dvyukov This PR has so many little changes to the tricky parts of the code that there's a high risk that I introduced some new concurrency/synchronization bugs to syzkaller. The PR needs a careful code review. If there's any way to do those changes in a simpler way, please let me know. |
c2f73fb
to
bed36b4
Compare
On my workstation it fails specifically on the recently added
|
bed36b4
to
12fcd25
Compare
Ah, okay, the test fails on the upstream code as well -- we set |
9a61a88
to
91d031b
Compare
This enables graceful error handling in the caller code.
Apply necessary changes to pkg/flatrpc and pkg/manager as well.
There's a 15 minutes timer in the diff fuzzer that needs to be conditional on the context object.
91d031b
to
dd2261d
Compare
PTAL |
These calls prevent graceful error handling in the caller code. We should just return
error
and let individual tools decide what to do.