Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/email/lore: extract patch series #5656

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

a-nogikh
Copy link
Collaborator

@a-nogikh a-nogikh commented Jan 3, 2025

Another part of #5620.


Refactor the code to make it more reusable.
Add a method to extract specifically the list of new patch series.

@a-nogikh a-nogikh force-pushed the features/lore-series branch from 7456137 to 000f165 Compare January 8, 2025 10:19
@a-nogikh a-nogikh requested a review from tarasmadan January 8, 2025 14:45
pkg/email/lore/parse.go Outdated Show resolved Hide resolved
tarasmadan
tarasmadan previously approved these changes Jan 9, 2025
Copy link
Collaborator

@tarasmadan tarasmadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please extend comments to speed-up the code understanding process.

Refactor the code to make it more reusable.
Add a method to extract specifically the list of new patch series.
@a-nogikh a-nogikh added this pull request to the merge queue Jan 13, 2025
Merged via the queue into google:master with commit 249ceea Jan 13, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants