Git merge status-callback #30022
Merged
Git merge status-callback #30022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
wangxf123456
force-pushed
the
merge-status-callback
branch
from
2e6a545 to
76f7a7b
Compare
rwgk
approved these changes
Apr 4, 2023
include/pybind11/functional.h
Outdated
| struct func_wrapper_base { | ||
| func_handle hfunc; | ||
| return_value_policy_pack rvpp; | ||
| explicit func_wrapper_base(func_handle &&hf, const return_value_policy_pack &rvpp) noexcept |
There was a problem hiding this comment.
This explicit is not longer accurate/needed.
copybara-service bot
pushed a commit
to pybind/pybind11_abseil
that referenced
this pull request
Jan 9, 2024
…ns to capture C++ exceptions. This change builds on google/pybind11clif#30022. PiperOrigin-RevId: 597047935
rwgk
added a commit
to google/clif
that referenced
this pull request
Jan 22, 2024
…ns to capture C++ exceptions. BEGIN_PUBLIC Change pybind11 handling of callbacks with `Status`, `StatusOr` returns to capture C++ exceptions. This change builds on google/pybind11clif#30022. END_PUBLIC The CL is mainly moving the `type_caster_std_function_specializations` code block from * google3/third_party/clif/pybind11/type_casters.h;l=42-74;rcl=532883006 into google3/third_party/pybind11_abseil/status_caster.h & google3/third_party/pybind11_abseil/statusor_caster.h. Additionally, the behavior for callbacks with a `Status` return is changed (`catch` `cast_error` in status_caster.h), to ensure that C++ exceptions do not unwind through C++ code built with exception handling disabled (see e.g. google3/third_party/pybind11_abseil/compat/README.md). Note that the added related test code (`testStatusWrongReturnType` in status_testing_no_cpp_eh_test_lib.py) exposed a behavior difference between PyCLIF-C-API and pybind11: returned objects are simply ignored by PyCLIF-C-API. Addressing this is left for later. All other changes are mainly to reorganize and expand the test code. (Note that the extensive, multi-year refactoring work around `Status`, `StatusOr`, `StatusNotOk` has left the related test code in a fairly unorganized state.) Notes for completeness: * This is a fairly fundamental behavior change, but somewhat surprisingly cl/596532587 was the only adjustment needed in google3. * TGP tested via child cl/578064081, which is only a very small additional production code change (fixing a very obvious bug), and will be submitted shortly after this CL. PiperOrigin-RevId: 597047935
This was referenced Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merge pybind/pybind11#4597 (Allow specializations based on callback function return values and arguments) with pywrapcc.
Additionally make
func_wrapperusereturn_value_policy_pack.