Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default timeout for fastboot command #959

Merged
merged 4 commits into from
Mar 18, 2025
Merged

Conversation

ko1in1u
Copy link
Collaborator

@ko1in1u ko1in1u commented Mar 18, 2025

This is a follow-up fix for PR952. Without setting up the default values, existing tests from other users may break since their tests are missing timeout arg.


This change is Reviewable

@ko1in1u ko1in1u added the bug label Mar 18, 2025
@ko1in1u ko1in1u added this to the Mobly Release 1.13 milestone Mar 18, 2025
@ko1in1u ko1in1u requested a review from xpconanfan March 18, 2025 22:07
@ko1in1u ko1in1u self-assigned this Mar 18, 2025
@xpconanfan
Copy link
Collaborator

Let's add a test for calling fastboot without timeout specified.

@ko1in1u
Copy link
Collaborator Author

ko1in1u commented Mar 18, 2025

Let's add a test for calling fastboot without timeout specified.

Added two unittest.

@xpconanfan
Copy link
Collaborator

CI is failing

@ko1in1u
Copy link
Collaborator Author

ko1in1u commented Mar 18, 2025

CI is failing

Run pyink for auto formatting Python files.

@ko1in1u ko1in1u requested a review from xpconanfan March 18, 2025 23:19
@ko1in1u ko1in1u merged commit 93e4847 into google:master Mar 18, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants