Remove empty arg/kwargs from es_trainer_lib #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
Created using spr 1.3.4 [skip ci]
boomanaiden154
added a commit
to boomanaiden154/ml-compiler-opt
that referenced
this pull request
Feb 9, 2025
This just passed empty strings which meant that implemented workers needed to accept these arguments for no reason. We should not be passing any arguments and let all the configuration on the worker side happen through gin. Pull Request: google#432
Created using spr 1.3.4 [skip ci]
boomanaiden154
added a commit
to boomanaiden154/ml-compiler-opt
that referenced
this pull request
Feb 20, 2025
This just passed empty strings which meant that implemented workers needed to accept these arguments for no reason. We should not be passing any arguments and let all the configuration on the worker side happen through gin. Pull Request: google#432
mtrofin
approved these changes
Feb 20, 2025
boomanaiden154
added a commit
to boomanaiden154/ml-compiler-opt
that referenced
this pull request
Feb 20, 2025
This just passed empty strings which meant that implemented workers needed to accept these arguments for no reason. We should not be passing any arguments and let all the configuration on the worker side happen through gin. Pull Request: google#432
Created using spr 1.3.4 [skip ci]
boomanaiden154
changed the base branch from
spr/boomanaiden154/main.remove-empty-argkwargs-from-es_trainer_lib
to
main
boomanaiden154
deleted the
spr/boomanaiden154/remove-empty-argkwargs-from-es_trainer_lib
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just passed empty strings which meant that implemented workers needed to
accept these arguments for no reason. We should not be passing any arguments
and let all the configuration on the worker side happen through gin.