Add ruff to the testing (#421)

https://docs.astral.sh/ruff https://docs.astral.sh/ruff/linter As suggested in #420. Co-authored-by: Aiden Grossman <aidengrossman@google.com>
google · Jan 29, 2025 · 4893898 · 4893898
1 parent 1851281
commit 4893898
Show file tree

Hide file tree

Showing 4 changed files with 37 additions and 6 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -43,12 +43,14 @@ jobs:
     strategy:
       matrix:
         python-version: ${{ fromJSON(needs.Envvars.outputs.version_matrix) }}
-        task: [Typecheck, Lint, Yapf, Test]
+        task: [Typecheck, Lint, Ruff, Yapf, Test]
         include:
           - task: Typecheck
             cmd: pytype -j auto .
           - task: Lint
             cmd: pylint --rcfile .pylintrc --recursive yes .
+          - task: Ruff
+            cmd: ruff check
           - task: Yapf
             cmd: yapf . -drp
           - task: Test

diff --git a/Pipfile b/Pipfile
@@ -16,8 +16,8 @@ pylint = "==3.3.2"
 pytest = "==8.3.4"
 pytype = "==2024.10.11"
 yapf = "==0.43.0"
+ruff = "==0.9.3"
 
 [ci]
 joblib = "==1.4.2"
 shap = "==0.46.0"
-
diff --git a/Pipfile.lock b/Pipfile.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -1,7 +1,12 @@
-# DO always create a tracking issue when allow-listing warnings
-# DO NOT disable warnings-as-error: warnings of today are tomorrow's evolvability blocker.
+[tool.ruff]
+line-length = 103
+lint.select = [ "C40", "C9", "E", "F", "PERF", "W" ]
+lint.ignore = [ "E722", "E731", "E741", "F401", "PERF203" ]
+lint.mccabe.max-complexity = 18
 
 [tool.pytest.ini_options]
+# DO always create a tracking issue when allow-listing warnings
+# DO NOT disable warnings-as-error: warnings of today are tomorrow's evolvability blocker.
 filterwarnings = [
   # Treat warnings as errors
   "error",