Support newer ffmpeg #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conchylicultor
requested changes
Apr 9, 2025
| ] | ||
| command = [_get_ffmpeg_path(), '-nostdin', '-i', str(path)] | ||
|
|
||
| older_ffmpeg_version = False |
There was a problem hiding this comment.
I don't understand. If the value is hardcoded, shouldn't this be removed ? Only the new command could be kept
There was a problem hiding this comment.
Yes it would be fine to keep only the new command.
I wasn't sure if it was useful to document the change this way.
There was a problem hiding this comment.
Ok, I'll update the code from my end before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The more recent versions of ffmpeg (including 6.1.1-3ubuntu5 which is the default in github.com ubuntu:latest) no longer output
"frame= *(\d+)"using the old command invocation in_get_video_metadata().This results in issue #44.
We overcome this be replacing the command invocation to use
['-acodec', 'copy', '-vf', 'select=1', '-vsync', '0']rather than['-acodec', 'copy', '-vcodec', 'copy']. This is backwards compatible with the older ffmpeg.For github actions to work correctly, it was necessary to update the action version numbers.