-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: capture mode UI and UiState #303
Draft
Kimblebee
wants to merge
16
commits into
kim/refactor/captureModes/update_useCaseMode_to_captureMode
Choose a base branch
from
kim/refactor/captureModes/captureMode_Ui
base: kim/refactor/captureModes/update_useCaseMode_to_captureMode
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
WIP: capture mode UI and UiState #303
Kimblebee
wants to merge
16
commits into
kim/refactor/captureModes/update_useCaseMode_to_captureMode
from
kim/refactor/captureModes/captureMode_Ui
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctor/captureModes/update_useCaseMode_to_captureMode
remove a change intended for another branch
…_to_captureMode # Conflicts: # feature/preview/src/main/java/com/google/jetpackcamera/feature/preview/quicksettings/QuickSettingsScreen.kt
…Mode' into kim/refactor/captureModes/captureMode_Ui
…ctor/captureModes/update_useCaseMode_to_captureMode
…Mode' into kim/refactor/captureModes/captureMode_Ui
Kimblebee
changed the title
WIP capture mode UI and UiState
WIP: capture mode UI and UiState
Jan 8, 2025
Kimblebee
force-pushed
the
kim/refactor/captureModes/update_useCaseMode_to_captureMode
branch
from
January 29, 2025 12:35
9e73f33
to
0c9b385
Compare
string resources for capture mode ui component
…Mode' into kim/refactor/captureModes/captureMode_Ui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change creates a UiState and UI Component to set the Capture Mode. The UI changes for the bottom capture controls will be handled in a separate PR.
WIP screenshots