update UseCaseMode to CaptureMode #300
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # core/camera/src/main/java/com/google/jetpackcamera/core/camera/CameraXCameraUseCase.kt # feature/settings/src/main/java/com/google/jetpackcamera/settings/SettingsViewModel.kt # feature/settings/src/main/java/com/google/jetpackcamera/settings/ui/SettingsComponents.kt
# Conflicts: # feature/preview/src/main/java/com/google/jetpackcamera/feature/preview/quicksettings/QuickSettingsScreen.kt
# Conflicts: # feature/preview/src/main/java/com/google/jetpackcamera/feature/preview/quicksettings/QuickSettingsScreen.kt
…thub.com/google/jetpack-camera-app into kim/refactor/captureMode_to_streamConfig
Base automatically changed from
kim/refactor/captureMode_to_streamConfig
to
main
January 11, 2025 00:31
Kimblebee
force-pushed
the
kim/refactor/captureModes/update_useCaseMode_to_captureMode
branch
from
1114773 to
9e73f33
Compare
…ctor/captureModes/update_useCaseMode_to_captureMode
…ctor/captureModes/update_useCaseMode_to_captureMode
…ctor/captureModes/update_useCaseMode_to_captureMode
Kimblebee
force-pushed
the
kim/refactor/captureModes/update_useCaseMode_to_captureMode
branch
from
9e73f33 to
0c9b385
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
effectively convert
UseCaseModetoCaptureMode, and move intoCameraAppSettings.Update references to UseCaseMode account for captureMode now residing in
CameraAppSettings.CameraAppSettings.applyPreviewMode()in viewModel to initialize the CameraAppSettings captureMode toVIDEO_ONLYorIMAGE_ONLYif the PreviewMode doesn't supportSTANDARD