Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zoom Refactor #293

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Zoom Refactor #293

wants to merge 18 commits into from

Conversation

Kimblebee
Copy link
Collaborator

@Kimblebee Kimblebee commented Dec 10, 2024 •
edited
Loading

Refactors current zoom code to improve code readability, flexibility, and display accuracy.

  • Rename values using zoomscale/zoomratio to be more readable
  • supports setting zoom via a scaling factor, directly with a zoom ratio, or directly with a linear zoom value (linear not yet implemented)
  • The zoom display on the preview screen is accurate always
  • Changes made to zoom, lensfacing, and mute during a recording will be reset to their pre-recording values

@Kimblebee Kimblebee marked this pull request as ready for review January 21, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Kimblebee