Reassign structlit test todos, add tests #258
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider this piece of SSA graph:
The corresponding code is:
Currently, the assigned issue is #97. While I think fixing #97 may solve this case, when I originally wrote these tests the intent was to capture the fact that if you put a source value into a locally allocated struct, that struct should be tainted. Now that I'm taking a fresh look at this, I believe the test case I wanted to write was:
The SSA graph for this one is basically the same, with an extra
MakeInterface
step (and without the path involving thecore.Innocuous
value).In all of these cases (but this is especially clear in the cases involving
interface{}
fields), propagation doesn't make it through theAlloc
, so taint doesn't reach the sink. To me, this seems like it's a closer fit for #212.