Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/login: provide a Stringer on the v1 GLOME URLResponse #203

Merged
merged 1 commit into from
Feb 26, 2025
Merged

go/login: provide a Stringer on the v1 GLOME URLResponse #203

merged 1 commit into from
Feb 26, 2025

Conversation

lukegb
Copy link
Collaborator

@lukegb lukegb commented Feb 26, 2025

No description provided.

pkern
pkern approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@pkern pkern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkern
pkern requested changes Feb 26, 2025
View reviewed changes
Copy link
Member

@pkern pkern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

login/login.go:188:9: cannot use sb (variable of type strings.Builder) as string value in return statement Hah, I wondered how that worked. Turns out it doesn't. :P

@lukegb
Copy link
Collaborator Author

lukegb commented Feb 26, 2025

login/login.go:188:9: cannot use sb (variable of type strings.Builder) as string value in return statement Hah, I wondered how that worked. Turns out it doesn't. :P

Should be fixed now... whoops.

@pkern pkern merged commit 4abe368 into master Feb 26, 2025
12 of 13 checks passed
@pkern pkern deleted the go-stringer branch February 26, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkern pkern pkern approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukegb @pkern