Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

genai: custom http client produces an error about "gRPC dial options" #151

Closed
eliben opened this issue Jun 27, 2024 · 7 comments
Closed
Labels
type:api-issue issue with the underlying API/service

Comments

@eliben
Copy link
Member

eliben commented Jun 27, 2024

Description of the bug:

This is because the caching client is created with gRPC now (the REST one isn't working in the API)

Actual vs expected behavior:

No response

Any other information you'd like to share?

No response

@eliben eliben added the type:bug Something isn't working label Jun 27, 2024
eliben added a commit that referenced this issue Jun 27, 2024
@eliben eliben added type:api-issue issue with the underlying API/service and removed type:bug Something isn't working labels Jun 27, 2024
eliben added a commit that referenced this issue Jun 28, 2024
@eliben
Copy link
Member Author

eliben commented Nov 18, 2024

Reran this test locally recently.

Now it fails with:

creating cache client: google: could not find default credentials. See https://cloud.google.com/docs/authentication/external/set-up-adc for more information

@jba

@jba
Copy link
Collaborator

jba commented Nov 18, 2024

What is the exact command?

When I run all the tests from the repo root with go test -v ./..., I see only two failures, in TestLive/tools/direct and TestLive/files. Neither mentions ADC.

It's possible you have to run gcloud auth application-default login.

@eliben
Copy link
Member Author

eliben commented Nov 18, 2024

What is the exact command?

When I run all the tests from the repo root with go test -v ./..., I see only two failures, in TestLive/tools/direct and TestLive/files. Neither mentions ADC.

It's possible you have to run gcloud auth application-default login.

Why would users need to do a gcloud login though, this is the google AI SDK, not vertex?

@eliben
Copy link
Member Author

eliben commented Nov 18, 2024

What is the exact command?

When I run all the tests from the repo root with go test -v ./..., I see only two failures, in TestLive/tools/direct and TestLive/files. Neither mentions ADC.

fwiw, #224 should fix some of the files failures (the API expectations changed)

@leventov
Copy link

@jba
Copy link
Collaborator

jba commented Jan 2, 2025

@leventov, according to the thread you linked above, you have a solution. I agree that the solution could be nicer, but other than that, is there any action we should take?

@jba
Copy link
Collaborator

jba commented Jan 17, 2025

We recommend switching to the new client, google.golang.org/genai, and filing bugs on its issue tracker.

@jba jba closed this as completed Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:api-issue issue with the underlying API/service
Projects
None yet
Development

No branches or pull requests

3 participants