Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monomakh: Version 1.200; ttfautohint (v1.8.4.7-5d5b) added #8991

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

yanone
Copy link
Collaborator

@yanone yanone commented Jan 23, 2025

Taken from the upstream repo https://github.com/slavonic/Monomakh at commit slavonic/Monomakh@762ecd9.

Resolves #8982

PR Checklist:

  • tags are added for NEW FONTS
  • primary_script definition in the METADATA.pb file for all projects that have a primary non-Latin based language support target
  • subsets definitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsets chinese-hongkong, chinese-simplified, chinese-traditional, korean, japanese.
  • Fontbakery checks are reviewed and failing checks are resolved in collaboration with the upstream font development team

@yanone yanone added I New Font II Submission pending proposal for non-commissioned fonts suggested in the issue tracker P3 labels Jan 23, 2025
@yanone
Copy link
Collaborator Author

yanone commented Jan 23, 2025

Please ignore glyphset-related checks as this font is Cyrl-first and doesn't need to support GF_Latin_Core.

Copy link

FontBakery report

fontbakery version: 0.13.1

Experimental checks

These won't break the CI job for now, but will become effective after some time if nobody raises any concern.

[1] Monomakh-Regular.ttf
💥 ERROR Check base characters have non-zero advance width. base_has_width
  • 💥 ERROR

    Failed with AttributeError: 'CheckRunContext' object has no attribute 'get'

  File "/opt/hostedtoolcache/Python/3.10.16/x64/lib/python3.10/site-packages/fontbakery/checkrunner.py", line 222, in _run_check
    subresults = list(subresults)
  File "/opt/hostedtoolcache/Python/3.10.16/x64/lib/python3.10/site-packages/fontbakery/checks/base_has_width.py", line 46, in check_base_has_width
    problems = bullet_list(context, problems)
  File "/opt/hostedtoolcache/Python/3.10.16/x64/lib/python3.10/site-packages/fontbakery/utils.py", line 155, in bullet_list
    return f"{indentation}{bullet} " + pretty_print_list(
  File "/opt/hostedtoolcache/Python/3.10.16/x64/lib/python3.10/site-packages/fontbakery/utils.py", line 140, in pretty_print_list
    if config.get("full_lists"):

[code: failed-check]

All other checks

[22] Monomakh-Regular.ttf
🔥 FAIL Shapes languages in all GF glyphsets. googlefonts/glyphsets/shape_languages
  • 🔥 FAIL

    GF_Phonetics_SinoExt glyphset:

FAIL messages Languages
Shaper didn't attach acutecomb to w cy_Latn (Welsh)
Some base glyphs were missing: ẞ de_Latn (German)
[code: failed-language-shaping]
  • ⚠️ WARN

    GF_Phonetics_SinoExt glyphset:

WARN messages Languages
Some auxiliary glyphs were missing: Ʒ, Ǥ, ǥ, Ǯ, ǯ, ʒ, ẞ fi_Latn (Finnish)
Some auxiliary glyphs were missing: ẞ fr_Latn (French), it_Latn (Italian), pl_Latn (Polish) and tr_Latn (Turkish)
[code: warning-language-shaping]
⚠️ WARN Check mark characters are in GDEF mark glyph class. opentype/gdef_mark_chars
  • ⚠️ WARN

    The following mark characters could be in the GDEF mark glyph class:
    uni0327 (U+0327) and uni0328 (U+0328)


    [code: mark-chars]
⚠️ WARN Check if each glyph has the recommended amount of contours. contour_count
  • ⚠️ WARN

    This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: uni0000	Contours detected: 2	Expected: 0
  • Glyph name: afii10070 Contours detected: 1 Expected: 2

  • Glyph name: uni0450 Contours detected: 2 Expected: 3

  • Glyph name: afii10071 Contours detected: 3 Expected: 4

  • Glyph name: afii10103 Contours detected: 1 Expected: 2

  • Glyph name: uni046E Contours detected: 1 Expected: 2

  • Glyph name: uni046F Contours detected: 1 Expected: 2

  • Glyph name: afii10195 Contours detected: 2 Expected: 3

  • Glyph name: uni0488 Contours detected: 16 Expected: 8

  • Glyph name: uni0489 Contours detected: 12 Expected: 8

  • 7 more.

Use -F or --full-lists to disable shortening of long lists.

[code: contour-count]
⚠️ WARN Check math signs have the same width. math_signs_width
  • ⚠️ WARN

    The most common width is 640 among a set of 8 math glyphs.
    The following math glyphs have a different width, though:

Width = 365: minus

[code: width-outliers]
⚠️ WARN Does the font contain a soft hyphen? soft_hyphen
  • ⚠️ WARN

    This font has a 'Soft Hyphen' character.


    [code: softhyphen]
⚠️ WARN Checking that the typoAscender exceeds the yMax of the /Agrave. typoascender_exceeds_Agrave
  • ⚠️ WARN

    OS/2.sTypoAscender value should be greater than 952, but got 932 instead


    [code: typoAscender]
⚠️ WARN Check font contains no unreachable glyphs unreachable_glyphs
  • ⚠️ WARN

    The following glyphs could not be reached by codepoint or substitution rules:

- uni0327.cap

- uni0328.cap

- uni2DEE.uni047E

[code: unreachable-glyphs]

⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets. googlefonts/article/images
  • ⚠️ WARN

    Family metadata at ofl/monomakh does not have an article.


    [code: lacks-article]
⚠️ WARN METADATA.pb: Designers are listed correctly on the Google Fonts catalog? googlefonts/metadata/designer_profiles
  • ⚠️ WARN

    It seems that Nikita Simmons is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry.


    [code: profile-not-found]
⚠️ WARN Check for codepoints not covered by METADATA subsets. googlefonts/metadata/unreachable_subsetting
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi
  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: math, tifinagh, cherokee, coptic
  • U+0305 COMBINING OVERLINE: try adding one of: elbasan, coptic, glagolitic, math, gothic
  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic
  • U+0307 COMBINING DOT ABOVE: try adding one of: old-permic, hebrew, duployan, coptic, tai-le, math, tifinagh, malayalam, todhri, canadian-aboriginal, syriac
  • U+030A COMBINING RING ABOVE: try adding one of: duployan, syriac
  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee
  • U+030C COMBINING CARON: try adding one of: cherokee, tai-le 173 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: cyrillic, cyrillic-ext, latin, latin-ext, menu

[code: unreachable-subsetting]
⚠️ WARN DESCRIPTION.en_us.html should end in a linebreak. googlefonts/description/eof_linebreak
  • ⚠️ WARN

    The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it.


    [code: missing-eof-linebreak]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. soft_dotted
  • ⚠️ WARN

    The dot of soft dotted characters used in orthographies must disappear in the following strings: і́

The dot of soft dotted characters should disappear in other cases, for example: i̅ i҄ i҇ i᷀ i᷁ iꚞ ị̅ ị̇ ị̊ ị̋ ị̌ ị̏ ị̑ ị̒ ị̓ ị̔ ị̾ ị҃ ị҄ ị҅

Your font fully covers the following languages that require the soft-dotted feature: Belarusian (Cyrl, 10,064,517 speakers), Lithuanian (Latn, 2,357,094 speakers), Dutch (Latn, 31,709,104 speakers), Ukrainian (Cyrl, 29,273,587 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Kaska (Latn, 125 speakers), Southern Tutchone (Latn, 65 speakers), Yala (Latn, 200,000 speakers), Vute (Latn, 21,000 speakers), Makaa (Latn, 221,000 speakers), Northern Tutchone (Latn, 85 speakers), Ebira (Latn, 2,200,000 speakers), Bafut (Latn, 158,146 speakers), Ejagham (Latn, 120,000 speakers), Southern Kisi (Latn, 360,000 speakers), Heiltsuk (Latn, 300 speakers), Ma’di (Latn, 584,000 speakers), Mfumte (Latn, 79,000 speakers), Zapotec (Latn, 490,000 speakers), Fur (Latn, 1,230,163 speakers), Gulay (Latn, 250,478 speakers), Nateni (Latn, 100,000 speakers), Teke-Ebo (Latn, 260,000 speakers), Aghem (Latn, 38,843 speakers), Ekpeye (Latn, 226,000 speakers), Igbo (Latn, 27,823,640 speakers), Keliko (Latn, 63,000 speakers), Ngbaka (Latn, 1,020,000 speakers), Ikwere (Latn, 717,000 speakers), Longto (Latn, 5,000 speakers), Bete-Bendi (Latn, 100,000 speakers), Western Krahn (Latn, 97,800 speakers), Avokaya (Latn, 100,000 speakers), Dii (Latn, 71,000 speakers), Navajo (Latn, 166,319 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Sar (Latn, 500,000 speakers), Kom (Latn, 360,685 speakers), Lugbara (Latn, 2,200,000 speakers), Nzakara (Latn, 50,000 speakers), Dan (Latn, 1,099,244 speakers), Mango (Latn, 77,000 speakers), South Central Banda (Latn, 244,000 speakers), Basaa (Latn, 332,940 speakers), Cicipu (Latn, 44,000 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Abua (Latn, 25,000 speakers), Han (Latn, 6 speakers), Mundani (Latn, 34,000 speakers), Koonzime (Latn, 40,000 speakers).

[code: soft-dotted]
⚠️ WARN Do outlines contain any semi-vertical or semi-horizontal lines? outline_semi_vertical
  • ⚠️ WARN

    The following glyphs have semi-vertical/semi-horizontal lines:

* OE (U+0152): L<<985.0,0.0>--<538.0,1.0>>

* uniFE2F (U+FE2F): L<<-30.0,643.0>--<-415.0,642.0>>

[code: found-semi-vertical]

⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table. googlefonts/meta/script_lang_tags
  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]
⚠️ WARN Checking OS/2 achVendID. googlefonts/vendor_id
  • ⚠️ WARN

    OS/2 VendorID value ' ' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx


    [code: unknown]
ℹ️ INFO List all superfamily filepaths superfamily/list
  • ℹ️ INFO

    ofl/monomakh


    [code: family-path]
ℹ️ INFO Show hinting filesize impact. hinting_impact
  • ℹ️ INFO

    Hinting filesize impact:

ofl/monomakh/Monomakh-Regular.ttf
Dehinted Size 145.7kb
Hinted Size 224.8kb
Increase 79.2kb
Change 54.3 %
[code: size-impact]
ℹ️ INFO Font contains all required tables? required_tables
  • ℹ️ INFO

    This font contains the following optional tables:

- cvt 

- fpgm

- loca

- prep

- GPOS

- GSUB

- gasp

[code: optional-tables]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field. googlefonts/metadata/minisite_url
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL? googlefonts/description/git_url
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file googlefonts/description/has_article
  • ℹ️ INFO

    This font doesn't have an ARTICLE.en_us.html file.


    [code: missing-article]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? googlefonts/gasp
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table. googlefonts/STAT/axis_order
  • ℹ️ INFO

    All of the fonts lack a STAT table.


    [code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
1 0 1 14 54 8 158 0
0% 0% 0% 6% 23% 3% 67% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@m4rc1e m4rc1e merged commit ef354d5 into main Jan 24, 2025
9 checks passed
@m4rc1e m4rc1e deleted the gftools_packager_ofl_monomakh branch January 24, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I New Font II Submission pending proposal for non-commissioned fonts suggested in the issue tracker P3
Projects
Status: In Dev / PR Merged
Development

Successfully merging this pull request may close these issues.

Add Monomakh
2 participants