-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playwrite GB J: Version 1.003 added #8949
Conversation
Taken from the upstream repo https://github.com/TypeTogether/Playwrite at commit TypeTogether/Playwrite@c92b72c. Resolves #8852
This comment was marked as outdated.
This comment was marked as outdated.
FontBakery reportfontbakery version: 0.13.0 Check results[15] PlaywriteGBJ[wght].ttf🔥 FAIL METADATA.pb should contain at least "menu" and "latin" subsets. googlefonts/metadata/menu_and_latin
|
WARN messages | Languages |
---|---|
Some auxiliary glyphs were missing: ſ | de_Latn (German) and fr_Latn (French) |
Some auxiliary glyphs were missing: Ʒ, Ǥ, ǥ, Ǯ, ǯ, ʒ | fi_Latn (Finnish) |
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. soft_dotted
⚠️ WARNThe dot of soft dotted characters should disappear in other cases, for example: ị̀ ị́ ị̂ ị̃ ị̄ ị̆ ị̇ ị̈ ị̉ ị̊ ị̋ ị̌ ị̒ i̦̇ i̦̊ i̦̋ i̦̒ i̧̇ i̧̊ i̧̋
Your font fully covers the following languages that require the soft-dotted feature: Lithuanian (Latn, 2,357,094 speakers), Dutch (Latn, 31,709,104 speakers).
Your font does not cover the following languages that require the soft-dotted feature: Mundani (Latn, 34,000 speakers), Gulay (Latn, 250,478 speakers), Abua (Latn, 25,000 speakers), Makaa (Latn, 221,000 speakers), South Central Banda (Latn, 244,000 speakers), Ngbaka (Latn, 1,020,000 speakers), Cicipu (Latn, 44,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Igbo (Latn, 27,823,640 speakers), Kaska (Latn, 125 speakers), Southern Tutchone (Latn, 65 speakers), Han (Latn, 6 speakers), Dan (Latn, 1,099,244 speakers), Mango (Latn, 77,000 speakers), Teke-Ebo (Latn, 260,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Sar (Latn, 500,000 speakers), Fur (Latn, 1,230,163 speakers), Ejagham (Latn, 120,000 speakers), Dii (Latn, 71,000 speakers), Bafut (Latn, 158,146 speakers), Bete-Bendi (Latn, 100,000 speakers), Zapotec (Latn, 490,000 speakers), Basaa (Latn, 332,940 speakers), Navajo (Latn, 166,319 speakers), Western Krahn (Latn, 97,800 speakers), Mfumte (Latn, 79,000 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Belarusian (Cyrl, 10,064,517 speakers), Ma’di (Latn, 584,000 speakers), Ebira (Latn, 2,200,000 speakers), Kom (Latn, 360,685 speakers), Nateni (Latn, 100,000 speakers), Avokaya (Latn, 100,000 speakers), Keliko (Latn, 63,000 speakers), Aghem (Latn, 38,843 speakers), Yala (Latn, 200,000 speakers), Ekpeye (Latn, 226,000 speakers), Longto (Latn, 5,000 speakers), Ikwere (Latn, 717,000 speakers), Vute (Latn, 21,000 speakers), Heiltsuk (Latn, 300 speakers), Northern Tutchone (Latn, 85 speakers), Southern Kisi (Latn, 360,000 speakers), Koonzime (Latn, 40,000 speakers), Nzakara (Latn, 50,000 speakers), Lugbara (Latn, 2,200,000 speakers).
[code: soft-dotted]⚠️ WARN Check font follows the Google Fonts vertical metric schema googlefonts/vertical_metrics
⚠️ WARNWe recommend the absolute sum of the hhea metrics should be between 1.2-1.5x of the font's upm. This font has 1.65x (1650)
[code: bad-hhea-range]
ℹ️ INFO Check if OS/2 xAvgCharWidth is correct. opentype/xavgcharwidth
- ℹ️ INFO
OS/2 xAvgCharWidth is 644 but it should be 646 which corresponds to the average of the widths of all glyphs in the font. These are similar values, which may be a symptom of the slightly different calculation of the xAvgCharWidth value in font editors. There's further discussion on this at com.google.fonts/test/034: xAvgCharWidth bakery vs glyphs vs font val fonttools/fontbakery#1622
[code: xAvgCharWidth-close]
ℹ️ INFO List all superfamily filepaths superfamily/list
- ℹ️ INFO
ofl/playwritegbj
[code: family-path]
ℹ️ INFO Show hinting filesize impact. hinting_impact
- ℹ️ INFO
Hinting filesize impact:
ofl/playwritegbj/PlaywriteGBJ[wght].ttf | |
---|---|
Dehinted Size | 332.5kb |
Hinted Size | 332.6kb |
Increase | 24 bytes |
Change | 0.0 % |
ℹ️ INFO Font contains all required tables? required_tables
- ℹ️ INFO
This font contains the following optional tables:
- loca
- prep
- GPOS
- GSUB
- gasp
[code: optional-tables]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? googlefonts/gasp
- ℹ️ INFO
These are the ppm ranges declared on the gasp table:
PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®
[code: ranges]ℹ️ INFO Ensure fonts have ScriptLangTags declared on the 'meta' table. googlefonts/meta/script_lang_tags
-
ℹ️ INFO
Latn,af,ca,cs,cy,da,en,es,et,eu,fr,ga,hi,hr,hu,id,is,it,nl,no,pl,pt,ro,sk,sl,sv,tr,vi,wa,yo,zu
[code: dlng-tag] -
ℹ️ INFO
Latn,af,ca,cs,cy,da,en,es,et,eu,fr,ga,hi,hr,hu,id,is,it,nl,no,pl,pt,ro,sk,sl,sv,tr,vi,wa,yo,zu
[code: slng-tag]
ℹ️ INFO Font has old ttfautohint applied? googlefonts/old_ttfautohint
- ℹ️ INFO
Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.003']
[code: version-not-detected]
[15] PlaywriteGBJ-Italic[wght].ttf
🔥 FAIL METADATA.pb should contain at least "menu" and "latin" subsets. googlefonts/metadata/menu_and_latin
- 🔥 FAIL
Subsets "menu" and "latin" are mandatory, but METADATA.pb is missing "latin".
[code: missing]
⚠️ WARN Check for points out of bounds. opentype/points_out_of_bounds
⚠️ WARNThe following glyphs have coordinates which are out of bounds:
- ('Icaron', 85, 1105)
- ('Icaron', 85, 1108)
- ('Icaron', 85, 1119)
- ('Iogonek', -45, -222)
- ('Iogonek', -45, -185)
- ('Iogonek', -45, -158)
- ('Jcircumflex', 776, 967)
- ('Jcircumflex', 776, 963)
- ('Jcircumflex', 776, 952)
- ('dcaron', 753, 912) and 35 more.
Use -F or --full-lists to disable shortening of long lists.
This happens a lot when points are not extremes, which is usually bad. However, fixing this alert by adding points on extremes may do more harm than good, especially with italics, calligraphic-script, handwriting, rounded and other fonts. So it is common to ignore this message.
[code: points-out-of-bounds]⚠️ WARN Ensure variable fonts include an avar table. mandatory_avar_table
⚠️ WARNThis variable font does not have an avar table. Most variable fonts should include an avar table to correctly define axes progression rates.
[code: missing-avar]
⚠️ WARN Glyph names are all valid? valid_glyphnames
⚠️ WARNThe following glyph names may be too long for some legacy systems which may expect a maximum 31-characters length limit:
circumflexcomb_hookabovecomb.case
[code: legacy-long-names]
⚠️ WARN Check for codepoints not covered by METADATA subsets. googlefonts/metadata/unreachable_subsetting
⚠️ WARNThe following codepoints supported by the font are not covered by
any subsets defined in the font's metadata file, and will never
be served. You can solve this by either manually adding additional
subset declarations to METADATA.pb, or by editing the glyphset
definitions.
- U+0100 LATIN CAPITAL LETTER A WITH MACRON: try adding latin-ext
- U+0101 LATIN SMALL LETTER A WITH MACRON: try adding latin-ext
- U+0102 LATIN CAPITAL LETTER A WITH BREVE: try adding one of: vietnamese, latin-ext
- U+0103 LATIN SMALL LETTER A WITH BREVE: try adding one of: vietnamese, latin-ext
- U+0104 LATIN CAPITAL LETTER A WITH OGONEK: try adding latin-ext
- U+0105 LATIN SMALL LETTER A WITH OGONEK: try adding latin-ext
- U+0106 LATIN CAPITAL LETTER C WITH ACUTE: try adding latin-ext
- U+0107 LATIN SMALL LETTER C WITH ACUTE: try adding latin-ext
- U+0108 LATIN CAPITAL LETTER C WITH CIRCUMFLEX: try adding latin-ext
- U+0109 LATIN SMALL LETTER C WITH CIRCUMFLEX: try adding latin-ext 263 more.
Use -F or --full-lists to disable shortening of long lists.
Or you can add the above codepoints to one of the subsets supported by the font: menu
⚠️ WARN Shapes languages in all GF glyphsets. googlefonts/glyphsets/shape_languages
⚠️ WARNGF_Phonetics_SinoExt glyphset:
WARN messages | Languages |
---|---|
Some auxiliary glyphs were missing: ſ | de_Latn (German) and fr_Latn (French) |
Some auxiliary glyphs were missing: Ʒ, Ǥ, ǥ, Ǯ, ǯ, ʒ | fi_Latn (Finnish) |
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. soft_dotted
⚠️ WARNThe dot of soft dotted characters should disappear in other cases, for example: ị̀ ị́ ị̂ ị̃ ị̄ ị̆ ị̇ ị̈ ị̉ ị̊ ị̋ ị̌ ị̒ i̦̇ i̦̊ i̦̋ i̦̒ i̧̇ i̧̊ i̧̋
Your font fully covers the following languages that require the soft-dotted feature: Lithuanian (Latn, 2,357,094 speakers), Dutch (Latn, 31,709,104 speakers).
Your font does not cover the following languages that require the soft-dotted feature: Mundani (Latn, 34,000 speakers), Gulay (Latn, 250,478 speakers), Abua (Latn, 25,000 speakers), Makaa (Latn, 221,000 speakers), South Central Banda (Latn, 244,000 speakers), Ngbaka (Latn, 1,020,000 speakers), Cicipu (Latn, 44,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Igbo (Latn, 27,823,640 speakers), Kaska (Latn, 125 speakers), Southern Tutchone (Latn, 65 speakers), Han (Latn, 6 speakers), Dan (Latn, 1,099,244 speakers), Mango (Latn, 77,000 speakers), Teke-Ebo (Latn, 260,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Sar (Latn, 500,000 speakers), Fur (Latn, 1,230,163 speakers), Ejagham (Latn, 120,000 speakers), Dii (Latn, 71,000 speakers), Bafut (Latn, 158,146 speakers), Bete-Bendi (Latn, 100,000 speakers), Zapotec (Latn, 490,000 speakers), Basaa (Latn, 332,940 speakers), Navajo (Latn, 166,319 speakers), Western Krahn (Latn, 97,800 speakers), Mfumte (Latn, 79,000 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Belarusian (Cyrl, 10,064,517 speakers), Ma’di (Latn, 584,000 speakers), Ebira (Latn, 2,200,000 speakers), Kom (Latn, 360,685 speakers), Nateni (Latn, 100,000 speakers), Avokaya (Latn, 100,000 speakers), Keliko (Latn, 63,000 speakers), Aghem (Latn, 38,843 speakers), Yala (Latn, 200,000 speakers), Ekpeye (Latn, 226,000 speakers), Longto (Latn, 5,000 speakers), Ikwere (Latn, 717,000 speakers), Vute (Latn, 21,000 speakers), Heiltsuk (Latn, 300 speakers), Northern Tutchone (Latn, 85 speakers), Southern Kisi (Latn, 360,000 speakers), Koonzime (Latn, 40,000 speakers), Nzakara (Latn, 50,000 speakers), Lugbara (Latn, 2,200,000 speakers).
[code: soft-dotted]⚠️ WARN Check font follows the Google Fonts vertical metric schema googlefonts/vertical_metrics
⚠️ WARNWe recommend the absolute sum of the hhea metrics should be between 1.2-1.5x of the font's upm. This font has 1.65x (1650)
[code: bad-hhea-range]
ℹ️ INFO Check if OS/2 xAvgCharWidth is correct. opentype/xavgcharwidth
- ℹ️ INFO
OS/2 xAvgCharWidth is 644 but it should be 646 which corresponds to the average of the widths of all glyphs in the font. These are similar values, which may be a symptom of the slightly different calculation of the xAvgCharWidth value in font editors. There's further discussion on this at com.google.fonts/test/034: xAvgCharWidth bakery vs glyphs vs font val fonttools/fontbakery#1622
[code: xAvgCharWidth-close]
ℹ️ INFO List all superfamily filepaths superfamily/list
- ℹ️ INFO
ofl/playwritegbj
[code: family-path]
ℹ️ INFO Show hinting filesize impact. hinting_impact
- ℹ️ INFO
Hinting filesize impact:
ofl/playwritegbj/PlaywriteGBJ-Italic[wght].ttf | |
---|---|
Dehinted Size | 336.8kb |
Hinted Size | 336.8kb |
Increase | 24 bytes |
Change | 0.0 % |
ℹ️ INFO Font contains all required tables? required_tables
- ℹ️ INFO
This font contains the following optional tables:
- loca
- prep
- GPOS
- GSUB
- gasp
[code: optional-tables]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? googlefonts/gasp
- ℹ️ INFO
These are the ppm ranges declared on the gasp table:
PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®
[code: ranges]ℹ️ INFO Ensure fonts have ScriptLangTags declared on the 'meta' table. googlefonts/meta/script_lang_tags
-
ℹ️ INFO
Latn,af,ca,cs,cy,da,en,es,et,eu,fr,ga,hi,hr,hu,id,is,it,nl,no,pl,pt,ro,sk,sl,sv,tr,vi,wa,yo,zu
[code: dlng-tag] -
ℹ️ INFO
Latn,af,ca,cs,cy,da,en,es,et,eu,fr,ga,hi,hr,hu,id,is,it,nl,no,pl,pt,ro,sk,sl,sv,tr,vi,wa,yo,zu
[code: slng-tag]
ℹ️ INFO Font has old ttfautohint applied? googlefonts/old_ttfautohint
- ℹ️ INFO
Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.003']
[code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table. googlefonts/STAT/axis_order
- ℹ️ INFO
None of the fonts lack a STAT table.
And these are the most common STAT axis orderings:
('wght-ital', 2)
[code: summary]
Summary
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 2 | 14 | 83 | 15 | 345 | 0 |
0% | 0% | 0% | 3% | 18% | 3% | 75% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
Taken from the upstream repo https://github.com/TypeTogether/Playwrite at commit TypeTogether/Playwrite@c92b72c.
Resolves #8852
PR Checklist:
minisite_url
definition in the METADATA.pb file for commissioned projectstags
are added for NEW FONTSprimary_script
definition in the METADATA.pb file for all projects that have a primary non-Latin based language support targetsubsets
definitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsetschinese-hongkong
,chinese-simplified
,chinese-traditional
,korean
,japanese
.