Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Tag: /Purpose/Educational #8676

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

vv-monsalve
Copy link
Collaborator

@vv-monsalve vv-monsalve commented Nov 28, 2024

Hi @davelab6, @evanwadams

Following the conversation in the chat about this new tag

Evans agreement is good to go :)

This PR introduces a new Purpose/Educational category to filter projects like the Australian Edu families, Playwrite, and other fonts specifically intended for teaching writing.

tags/all/families.csv Outdated Show resolved Hide resolved
@davelab6
Copy link
Member

davelab6 commented Dec 4, 2024

I think /Purpose/Educational is a good cat/tag

@vv-monsalve
Copy link
Collaborator Author

I've updated the file and solved the merge conflict (by deleting the buggy line added). However, there is still a CI run check that is not finishing the job.
I don't know if that should be a blocker for this PR. @davelab6?

@davelab6
Copy link
Member

davelab6 commented Jan 15, 2025

@vv-monsalve please add more Educational tags :)

Evan confirmed to me just now that, when we add a new tag, it should be added across the whole type library, so no family that could have a tag value is missing one. So we'll hold this PR open until then.

Also, the team has not yet worked out the details of the overall Purpose tag category, and while we can add a new tag without a full plan for its parent category while we wait for that to get fleshed out, it won't show up anywhere (even if merged) until then.

@chrissimpkins
Copy link
Collaborator

chrissimpkins commented Jan 16, 2025

OK to add the rest of the families where the new Educational tag applies

@davelab6
Copy link
Member

I created b/390409291 internally to request a filters sidebar UI update for this new category; once data complete this can be merged without blocking on that

@vv-monsalve
Copy link
Collaborator Author

vv-monsalve commented Jan 16, 2025

List of the already-known families that could receive this tag:

  • ABeeZee
  • Borel
  • Edu Australia
  • Edu Tas
  • Edu SA
  • Playwrite (main + Guides)

@davelab6
Copy link
Member

@vv-monsalve I got confirmation that the UI update work will happen, so please proceed to review the whole library for other candidates to add to that list, if any add them to this PR, and then merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants