Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edu AU VIC WA NT Arrows: Version 1.001 added #8319

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

simoncozens
Copy link
Collaborator

Copy link

FontBakery report

fontbakery version: 0.13.0a1

Check results

[19] EduAUVICWANTArrows[wght].ttf
🔥 FAIL MaxAdvanceWidth is consistent with values in the Hmtx and Hhea tables?
  • 🔥 FAIL

    AdvanceWidthMax mismatch: expected 2337 (from hmtx); got 2586 (from hhea)


    [code: mismatch]
🔥 FAIL Checking correctness of monospaced metadata.
  • 🔥 FAIL

    Value of hhea.advanceWidthMax should be set to 2337 but got 2586 instead.


    [code: bad-advanceWidthMax]
🔥 FAIL Shapes languages in all GF glyphsets.
  • 🔥 FAIL

    No GF glyphset was found to be supported >80%, so language shaping support couldn't get checked.


    [code: no-glyphset-supported]
🔥 FAIL Check Google Fonts glyph coverage.
  • 🔥 FAIL

    Missing required codepoints:

- 0x0021 (EXCLAMATION MARK)


- 0x0022 (QUOTATION MARK)


- 0x0023 (NUMBER SIGN)


- 0x0024 (DOLLAR SIGN)


- 0x0025 (PERCENT SIGN)


- 0x0026 (AMPERSAND)


- 0x0027 (APOSTROPHE)


- 0x0028 (LEFT PARENTHESIS)


- 0x0029 (RIGHT PARENTHESIS)


- 0x002A (ASTERISK)


- 245 more.

Use -F or --full-lists to disable shortening of long lists.

[code: missing-codepoints]
⚠️ WARN Font has correct post table version?
  • ⚠️ WARN

    Post table format 3 use has niche use case problems.Please review the check rationale for additional details.


    [code: post-table-version]
⚠️ WARN Check if OS/2 xAvgCharWidth is correct.
  • ⚠️ WARN

    OS/2 xAvgCharWidth is 1129 but it should be 1179 which corresponds to the average of the widths of all glyphs in the font.


    [code: xAvgCharWidth-wrong]
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
  • ⚠️ WARN

    Family metadata at ofl/eduauvicwantarrows does not have an article.


    [code: lacks-article]
⚠️ WARN Are there any misaligned on-curve points?
  • ⚠️ WARN

    The following glyphs have on-curve points which have potentially incorrect y coordinates:

* J (U+004A): X=-0.5,Y=2.0 (should be at baseline 0?)

* K (U+004B): X=1495.0,Y=1848.5 (should be at cap-height 1847?)

* Q (U+0051): X=718.0,Y=-1.0 (should be at baseline 0?)

* V (U+0056): X=1320.5,Y=1845.0 (should be at cap-height 1847?)

* W (U+0057): X=2273.5,Y=1845.0 (should be at cap-height 1847?)

* X (U+0058): X=948.0,Y=1.0 (should be at baseline 0?)

* Y (U+0059): X=1224.5,Y=1849.0 (should be at cap-height 1847?)

* Y (U+0059): X=1302.5,Y=1847.5 (should be at cap-height 1847?)

* c (U+0063): X=585.0,Y=994.0 (should be at x-height 995?)

* d (U+0064): X=994.5,Y=1845.5 (should be at cap-height 1847?)

* 19 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-misalignments]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]
⚠️ WARN Check font follows the Google Fonts vertical metric schema
  • ⚠️ WARN

    We recommend the absolute sum of the hhea metrics should be between 1.2-1.5x of the font's upm. This font has 1.7395x (3479)


    [code: bad-hhea-range]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/eduauvicwantarrows


    [code: family-path]
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/eduauvicwantarrows/EduAUVICWANTArrows[wght].ttf
Dehinted Size 63.6kb
Hinted Size 63.6kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

- vhea

- vmtx

[code: optional-tables]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
  • ℹ️ INFO

    This font doesn't have an ARTICLE.en_us.html file.


    [code: missing-article]
ℹ️ INFO EPAR table present in font?
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.001']


    [code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wght', 1)

[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 4 6 53 10 180 0
0% 0% 2% 2% 21% 4% 71% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@emmamarichal emmamarichal linked an issue Oct 11, 2024 that may be closed by this pull request
@emmamarichal
Copy link
Collaborator

@simoncozens These two fails seem to be a related to a width/spacing particularity:

🔥 FAIL MaxAdvanceWidth is consistent with values in the Hmtx and Hhea tables?
🔥 FAIL Checking correctness of monospaced metadata.

Should we correct that or this is related to the design and intentional?

@emmamarichal
Copy link
Collaborator

Otherwise, the font looks good to me.

@emmamarichal emmamarichal added the -- Needs confirmation from upstream or onboarder label Oct 24, 2024
@simoncozens
Copy link
Collaborator Author

This is a subsetter bug caused by harfbuzz/harfbuzz#4931 in Harfbuzz.

However, we have been serving fonts over the web API for years using Harfbuzz subsetting, and so with the same problem, but nobody has complained, so maybe it's not a big deal. :-)

@vv-monsalve vv-monsalve merged commit 8b77a15 into main Nov 8, 2024
8 checks passed
@vv-monsalve vv-monsalve deleted the gftools_packager_ofl_eduauvicwantarrows branch November 8, 2024 13:47
@vv-monsalve vv-monsalve removed the -- Needs confirmation from upstream or onboarder label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Live
Development

Successfully merging this pull request may close these issues.

Add Edu VIC WA NT Arrows
3 participants