-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edu VIC WA NT Starters: Version 1.000 added #7458
Conversation
Taken from the upstream repo https://github.com/SorkinType/VICWANTSchoolHandAustralia at commit SorkinType/VICWANTSchoolhandAustralia@abab94d.
FontBakery reportfontbakery version: 0.12.0a4 Experimental checksThese won't break the CI job for now, but will become effective after some time if nobody raises any concern. [1] EduVICWANTStarters[wght].ttfAll other checks[18] EduVICWANTStarters[wght].ttf
|
Language | FAIL messages |
---|---|
nl_Latn (Dutch) | Shaper didn't attach acutecomb to j |
[code: failed-language-shaping]
⚠️ **WARN** DESCRIPTION.en_us.html should end in a linebreak.
⚠️ WARN The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it. [code: missing-eof-linebreak]
ℹ️ **INFO** Does DESCRIPTION file contain a upstream Git repo URL?
- ℹ️ INFO Found a git repo URL: https://github.com/SorkinType/VICWANTSchoolHandAustralia [code: url-found]
ℹ️ **INFO** EPAR table present in font?
- ℹ️ INFO EPAR table not present in font. To learn more see When missing EPAR table, just emit INFO alert fonttools/fontbakery#818 [code: lacks-EPAR]
ℹ️ **INFO** Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
- ℹ️ INFO These are the ppm ranges declared on the gasp table:
PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]
ℹ️ **INFO** Show hinting filesize impact.
- ℹ️ INFO Hinting filesize impact:
ofl/eduvicwantstarters/EduVICWANTStarters[wght].ttf | |
---|---|
Dehinted Size | 359.7kb |
Hinted Size | 359.7kb |
Increase | 24 bytes |
Change | 0.0 % |
[code: size-impact] |
⚠️ **WARN** Is there kerning info for non-ligated sequences?
-
⚠️ WARN GPOS table lacks kerning info for the following non-ligated sequences:-
glyph00181 + glyph00190
-
glyph00190 + glyph00205 [code: lacks-kern-info]
-
⚠️ **WARN** Are there caret positions declared for every ligature?
⚠️ WARN This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]
⚠️ **WARN** Ensure fonts have ScriptLangTags declared on the 'meta' table.
⚠️ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
[1] Family checks
Summary
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 1 | 10 | 45 | 9 | 182 | 0 |
0% | 0% | 0% | 4% | 18% | 4% | 74% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
Being this a commissioned project, does it have a minisite URL? Please add it or cross out these points in the list for all the related PRs
The font should use soft-dotted glyphs to ensure on-the-fly composite glyphs. |
I'm not sure this is a commissioned project. |
I understood these were the Briem fonts, weren't they? I linked that issue in the development section of this PR. If it doesn't match the font, please modify that link to match the corresponding one. |
This is not related to Briem; it's the Australia School fonts, an existing libre font project: https://www.australianschoolfonts.com.au/ |
Is there an open issue for these fonts? Could you please add it to the Development section of the PRs as well as the required labels (e.g., if they are new or upgraded fonts) on all the PRs? This is required at onboarding time to review them better. |
The change will be done for all the Edu projects in a batch after merging
@EbenSorkin some outlines have the wrong direction and are creating for some shapes to not be visible (see the counter in the above image). |
Given that special variants like "dotted", "arrows" or "starters" are applied only to A-Z a-z and 0-9, we'll check with @davelab6 about how to proceed with the fonts. |
Done in #7484 (comment) |
Taken from the upstream repo https://github.com/SorkinType/VICWANTSchoolHandAustralia at commit SorkinType/VICWANTSchoolhandAustralia@abab94d.
PR Checklist:
- [ ] Minisite_url definition in the METADATA.pb file for commissioned projects- [ ] Primary_script definition in the METADATA.pb file for all projects that have a primary non-Latin based language support target