Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edu AU VIC WA NT Arrows: Version 1.000 added #7447

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

simoncozens
Copy link
Collaborator

Taken from the upstream repo https://github.com/SorkinType/VICWANTSchoolHandAustralia at commit SorkinType/VICWANTSchoolhandAustralia@abab94d.

PR Checklist:

  • Family categorization tags collected from the type design team with the Categories Form
  • Minisite_url definition in the METADATA.pb file for commissioned projects
  • Primary_script definition in the METADATA.pb file for all projects that have a primary non-Latin based language support target
  • Fontbakery checks are reviewed and failing checks are resolved in collaboration with the upstream font development team
  • Diffenator2 regression checks for revisions on all projects that are currently in production
  • Designers bio info have to be present in the designer catalog (at least an issue should be opened for tracking this, if they are not)
  • Check designers order in metadata.pb, since the first one of the list appears as “principal designer”
  • Social media formatted visual assets for all new commissioned projects in the Drive directory, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet
  • Social media content draft for all new commissioned projects in the Drive directory and Social Media tracker spreadsheet, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet

Copy link

FontBakery report

fontbakery version: 0.12.0a4

Experimental checks

These won't break the CI job for now, but will become effective after some time if nobody raises any concern.

[1] EduVICWANTArrows[wght].ttf
ℹ️ **INFO** METADATA.pb: Validate family.minisite_url field.
  • ℹ️ INFO Please consider adding a family.minisite_url entry. [code: lacks-minisite-url]

All other checks

[18] EduVICWANTArrows[wght].ttf
⚠️ **WARN** Font has correct post table version?
  • ⚠️ WARN Post table format 3 use has niche use case problems.Please review the check rationale for additional details. [code: post-table-version]
⚠️ **WARN** Check if OS/2 xAvgCharWidth is correct.
  • ⚠️ WARN OS/2 xAvgCharWidth is 1126 but it should be 1083 which corresponds to the average of the widths of all glyphs in the font. [code: xAvgCharWidth-wrong]
ℹ️ **INFO** List all superfamily filepaths
  • ℹ️ INFO ofl/eduvicwantarrows [code: family-path]
⚠️ **WARN** Check math signs have the same width.
  • ⚠️ WARN The most common width is 1017 among a set of 4 math glyphs.
    The following math glyphs have a different width, though:

Width = 961:
less

Width = 962:
greater

Width = 1042:
plusminus

Width = 1011:
multiply

Width = 1052:
approxequal

Width = 1037:
notequal

Width = 1039:
lessequal, greaterequal
[code: width-outliers]

ℹ️ **INFO** Font contains all required tables?
  • ℹ️ INFO This font contains the following optional tables:

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp

    • vhea

    • vmtx [code: optional-tables]

⚠️ **WARN** Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.
  • ⚠️ WARN The dot of soft dotted characters used in orthographies must disappear in the following strings: i̊ i̋ j̀ j́ j̃ j̄ j̈ į̀ į́ į̂ į̃ į̄ į̌

The dot of soft dotted characters should disappear in other cases, for example: ĭ i̇ ǐ i̒ ĭ̦ i̦̇ i̦̊ i̦̋ ǐ̦ i̦̒ ĭ̧ i̧̇ i̧̊ i̧̋ ǐ̧ i̧̒ ĵ j̆ j̇ j̊

Your font fully covers the following languages that require the soft-dotted feature: Lithuanian (Latn, 2,357,094 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Dan (Latn, 1,099,244 speakers), Dii (Latn, 71,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Ejagham (Latn, 120,000 speakers), Navajo (Latn, 166,319 speakers), Makaa (Latn, 221,000 speakers), Nzakara (Latn, 50,000 speakers), Basaa (Latn, 332,940 speakers), Ebira (Latn, 2,200,000 speakers), Ma’di (Latn, 584,000 speakers), Avokaya (Latn, 100,000 speakers), Fur (Latn, 1,230,163 speakers), Mango (Latn, 77,000 speakers), Cicipu (Latn, 44,000 speakers), Aghem (Latn, 38,843 speakers), Gulay (Latn, 250,478 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Bete-Bendi (Latn, 100,000 speakers), Dutch (Latn, 31,709,104 speakers), Bafut (Latn, 158,146 speakers), South Central Banda (Latn, 244,000 speakers), Nateni (Latn, 100,000 speakers), Zapotec (Latn, 490,000 speakers), Mfumte (Latn, 79,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Belarusian (Cyrl, 10,064,517 speakers), Southern Kisi (Latn, 360,000 speakers), Sar (Latn, 500,000 speakers), Kom (Latn, 360,685 speakers), Lugbara (Latn, 2,200,000 speakers), Ngbaka (Latn, 1,020,000 speakers), Igbo (Latn, 27,823,640 speakers), Mundani (Latn, 34,000 speakers), Yala (Latn, 200,000 speakers), Ekpeye (Latn, 226,000 speakers), Koonzime (Latn, 40,000 speakers). [code: soft-dotted]

⚠️ **WARN** Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: tifinagh, canadian-aboriginal, yi

  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi

  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi

  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi

  • U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition

  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: tifinagh, cherokee, math, coptic

  • U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh

  • U+0307 COMBINING DOT ABOVE: try adding one of: tifinagh, syriac, malayalam, tai-le, old-permic, canadian-aboriginal, coptic, math

  • U+030A COMBINING RING ABOVE: try adding syriac

  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage
    38 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu [code: unreachable-subsetting]

🔥 **FAIL** Shapes languages in all GF glyphsets.
  • 🔥 FAIL GF_Latin_Core glyphset:
Language FAIL messages
nl_Latn (Dutch) Shaper didn't attach acutecomb to j

[code: failed-language-shaping]

⚠️ **WARN** DESCRIPTION.en_us.html should end in a linebreak.
  • ⚠️ WARN The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it. [code: missing-eof-linebreak]
ℹ️ **INFO** Does DESCRIPTION file contain a upstream Git repo URL?
ℹ️ **INFO** EPAR table present in font?
ℹ️ **INFO** Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

ℹ️ **INFO** Show hinting filesize impact.
  • ℹ️ INFO Hinting filesize impact:
ofl/eduvicwantarrows/EduVICWANTArrows[wght].ttf
Dehinted Size 359.4kb
Hinted Size 359.4kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
⚠️ **WARN** Is there kerning info for non-ligated sequences?
  • ⚠️ WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • glyph00181 + glyph00190

    • glyph00190 + glyph00205 [code: lacks-kern-info]

⚠️ **WARN** Are there caret positions declared for every ligature?
  • ⚠️ WARN This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]
⚠️ **WARN** Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ⚠️ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
ℹ️ **INFO** Font has old ttfautohint applied?
  • ℹ️ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.000'] [code: version-not-detected]
⚠️ **WARN** Check font follows the Google Fonts vertical metric schema
  • ⚠️ WARN We recommend the absolute sum of the hhea metrics should be between 1.2-1.5x of the font's upm. This font has 1.7395x (3479) [code: bad-hhea-range]
[1] Family checks
ℹ️ **INFO** Check axis ordering on the STAT table.
  • ℹ️ INFO None of the fonts lack a STAT table.

    And these are the most common STAT axis orderings:
    ('wght', 1) [code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 1 10 45 9 182 0
0% 0% 0% 4% 18% 4% 74% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@simoncozens simoncozens mentioned this pull request Mar 28, 2024
9 tasks
@vv-monsalve vv-monsalve added the -- Needs Upstream Resolution Upstream fix required before moving forward label Apr 10, 2024
Copy link

FontBakery report

fontbakery version: 0.12.9

Experimental checks

These won't break the CI job for now, but will become effective after some time if nobody raises any concern.

[1] EduAUVICWANTArrows[wght].ttf
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
  • ⚠️ WARN

    Family metadata at ofl/eduauvicwantarrows does not have an article.


    [code: lacks-article]

All other checks

[18] EduAUVICWANTArrows[wght].ttf
🔥 FAIL Checking correctness of monospaced metadata.
  • 🔥 FAIL

    Value of hhea.advanceWidthMax should be set to 2337 but got 2586 instead.


    [code: bad-advanceWidthMax]
🔥 FAIL MaxAdvanceWidth is consistent with values in the Hmtx and Hhea tables?
  • 🔥 FAIL

    AdvanceWidthMax mismatch: expected 2337 (from hmtx); got 2586 (from hhea)


    [code: mismatch]
🔥 FAIL Shapes languages in all GF glyphsets.
  • 🔥 FAIL

    No GF glyphset was found to be supported >80%, so language shaping support couldn't get checked.


    [code: no-glyphset-supported]
🔥 FAIL Check Google Fonts glyph coverage.
  • 🔥 FAIL

    Missing required codepoints:

- 0x0021 (EXCLAMATION MARK)


- 0x0022 (QUOTATION MARK)


- 0x0023 (NUMBER SIGN)


- 0x0024 (DOLLAR SIGN)


- 0x0025 (PERCENT SIGN)


- 0x0026 (AMPERSAND)


- 0x0027 (APOSTROPHE)


- 0x0028 (LEFT PARENTHESIS)


- 0x0029 (RIGHT PARENTHESIS)


- 0x002A (ASTERISK)


- 245 more.

Use -F or --full-lists to disable shortening of long lists.

[code: missing-codepoints]
⚠️ WARN Font has correct post table version?
  • ⚠️ WARN

    Post table format 3 use has niche use case problems.Please review the check rationale for additional details.


    [code: post-table-version]
⚠️ WARN Check if OS/2 xAvgCharWidth is correct.
  • ⚠️ WARN

    OS/2 xAvgCharWidth is 1130 but it should be 1181 which corresponds to the average of the widths of all glyphs in the font.


    [code: xAvgCharWidth-wrong]
⚠️ WARN Are there any misaligned on-curve points?
  • ⚠️ WARN

    The following glyphs have on-curve points which have potentially incorrect y coordinates:

* J (U+004A): X=-0.5,Y=2.0 (should be at baseline 0?)

* K (U+004B): X=1495.0,Y=1848.5 (should be at cap-height 1847?)

* Q (U+0051): X=718.0,Y=-1.0 (should be at baseline 0?)

* V (U+0056): X=1320.5,Y=1845.0 (should be at cap-height 1847?)

* W (U+0057): X=2273.5,Y=1845.0 (should be at cap-height 1847?)

* X (U+0058): X=948.0,Y=1.0 (should be at baseline 0?)

* Y (U+0059): X=1224.5,Y=1849.0 (should be at cap-height 1847?)

* Y (U+0059): X=1302.5,Y=1847.5 (should be at cap-height 1847?)

* c (U+0063): X=585.0,Y=994.0 (should be at x-height 995?)

* d (U+0064): X=994.5,Y=1845.5 (should be at cap-height 1847?)

* 20 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-misalignments]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]
⚠️ WARN Check font follows the Google Fonts vertical metric schema
  • ⚠️ WARN

    We recommend the absolute sum of the hhea metrics should be between 1.2-1.5x of the font's upm. This font has 1.7395x (3479)


    [code: bad-hhea-range]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/eduauvicwantarrows


    [code: family-path]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

- vhea

- vmtx

[code: optional-tables]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
  • ℹ️ INFO

    This font doesn't have an ARTICLE.en_us.html file.


    [code: missing-article]
ℹ️ INFO EPAR table present in font?
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/eduauvicwantarrows/EduAUVICWANTArrows[wght].ttf
Dehinted Size 63.3kb
Hinted Size 63.3kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.001']


    [code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wght', 1)

[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 4 6 52 10 180 0
0% 0% 2% 2% 21% 4% 71% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@simoncozens
Copy link
Collaborator Author

This is a deliberately minimal subset (A-Za-z0-9), and we are OK with that. This explains most of the FB FAILs.

@simoncozens simoncozens removed the -- Needs Upstream Resolution Upstream fix required before moving forward label Aug 13, 2024
@simoncozens simoncozens linked an issue Aug 13, 2024 that may be closed by this pull request
9 tasks
@vv-monsalve vv-monsalve merged commit 869ddb7 into main Aug 15, 2024
7 checks passed
@vv-monsalve vv-monsalve deleted the gftools_packager_ofl_eduvicwantarrows branch August 15, 2024 20:15
@vv-monsalve
Copy link
Collaborator

@simoncozens I merged it and then remembered this fails.

🔥 FAIL Checking correctness of monospaced metadata.
🔥 FAIL
Value of hhea.advanceWidthMax should be set to 2337 but got 2586 instead.
[code: bad-advanceWidthMax]

🔥 FAIL MaxAdvanceWidth is consistent with values in the Hmtx and Hhea tables?
🔥 FAIL
AdvanceWidthMax mismatch: expected 2337 (from hmtx); got 2586 (from hhea)
[code: mismatch]

After a quick revision to the htmx table, I can confirm there is no 2586 value.

@simoncozens
Copy link
Collaborator Author

It's fine, the way the average is calculated is confused by these small glyphsets.

@vv-monsalve
Copy link
Collaborator

But the hhea.advanceWidthMax == higher value in htmx, right? In this case, it is not a calculated value.

And the second FAIL is complaining about the mismatch :)

@vv-monsalve
Copy link
Collaborator

vv-monsalve commented Aug 16, 2024

Working on the tagging effort, I've noticed the first Edu family merged as a benchmark included the AU particle in the name and 'Australia' in the display name: display_name: "Edu Australia VIC WA NT Hand"

We had agreed on a unified naming strategy, in which case this font should be updated accordingly.

@vv-monsalve vv-monsalve added the -- Needs Upstream Resolution Upstream fix required before moving forward label Aug 16, 2024
@simoncozens simoncozens changed the title Edu VIC WA NT Arrows: Version 1.000 added Edu AU VIC WA NT Arrows: Version 1.000 added Aug 18, 2024
@vv-monsalve
Copy link
Collaborator

Currently display_name: "Edu AU VIC WA NT Hand Arrows"
Should be display_name: "Edu Australia VIC WA NT Hand Arrows"

@vv-monsalve
Copy link
Collaborator

But the hhea.advanceWidthMax == higher value in htmx, right? In this case, it is not a calculated value.

And the second FAIL is complaining about the mismatch :)

What about this?

@vv-monsalve
Copy link
Collaborator

vv-monsalve commented Aug 20, 2024

Currently display_name: "Edu AU VIC WA NT Hand Arrows" Should be display_name: "Edu Australia VIC WA NT Hand Arrows"

I've fixed the above. However, inspecting this again, similar to the Arrows-Guides variant the figures need to include the arrows.

Screenshot 2024-08-20 at 17 14 45

It needs to be updated to unblock it.

cc @EbenSorkin

@EbenSorkin
Copy link
Collaborator

EbenSorkin commented Aug 20, 2024 via email

@emmamarichal
Copy link
Collaborator

Arrows Guide version is almost ready (some menu issues need to be solved). #7873
Should we stop tracking this one, so Simon can create a new PR (following also the Arrows Guide corrections)?

@vv-monsalve @simoncozens

@vv-monsalve
Copy link
Collaborator

Should we stop tracking this one, so Simon can create a new PR (following also the Arrows Guide corrections)?

This would be best, yes. I've confirmed it's already blocked.
@simoncozens please remember to update this one after solving #7873

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-- Needs Upstream Resolution Upstream fix required before moving forward I New Font
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants