-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edu AU VIC WA NT Arrows: Version 1.000 added #7447
Conversation
Taken from the upstream repo https://github.com/SorkinType/VICWANTSchoolHandAustralia at commit SorkinType/VICWANTSchoolhandAustralia@abab94d.
FontBakery reportfontbakery version: 0.12.0a4 Experimental checksThese won't break the CI job for now, but will become effective after some time if nobody raises any concern. [1] EduVICWANTArrows[wght].ttfAll other checks[18] EduVICWANTArrows[wght].ttf
|
Language | FAIL messages |
---|---|
nl_Latn (Dutch) | Shaper didn't attach acutecomb to j |
[code: failed-language-shaping]
⚠️ **WARN** DESCRIPTION.en_us.html should end in a linebreak.
⚠️ WARN The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it. [code: missing-eof-linebreak]
ℹ️ **INFO** Does DESCRIPTION file contain a upstream Git repo URL?
- ℹ️ INFO Found a git repo URL: https://github.com/SorkinType/VICWANTSchoolHandAustralia [code: url-found]
ℹ️ **INFO** EPAR table present in font?
- ℹ️ INFO EPAR table not present in font. To learn more see When missing EPAR table, just emit INFO alert fonttools/fontbakery#818 [code: lacks-EPAR]
ℹ️ **INFO** Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
- ℹ️ INFO These are the ppm ranges declared on the gasp table:
PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]
ℹ️ **INFO** Show hinting filesize impact.
- ℹ️ INFO Hinting filesize impact:
ofl/eduvicwantarrows/EduVICWANTArrows[wght].ttf | |
---|---|
Dehinted Size | 359.4kb |
Hinted Size | 359.4kb |
Increase | 24 bytes |
Change | 0.0 % |
[code: size-impact] |
⚠️ **WARN** Is there kerning info for non-ligated sequences?
-
⚠️ WARN GPOS table lacks kerning info for the following non-ligated sequences:-
glyph00181 + glyph00190
-
glyph00190 + glyph00205 [code: lacks-kern-info]
-
⚠️ **WARN** Are there caret positions declared for every ligature?
⚠️ WARN This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]
⚠️ **WARN** Ensure fonts have ScriptLangTags declared on the 'meta' table.
⚠️ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
[1] Family checks
Summary
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 1 | 10 | 45 | 9 | 182 | 0 |
0% | 0% | 0% | 4% | 18% | 4% | 74% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
FontBakery reportfontbakery version: 0.12.9 Experimental checksThese won't break the CI job for now, but will become effective after some time if nobody raises any concern. [1] EduAUVICWANTArrows[wght].ttfAll other checks[18] EduAUVICWANTArrows[wght].ttf🔥 FAIL Checking correctness of monospaced metadata.
🔥 FAIL MaxAdvanceWidth is consistent with values in the Hmtx and Hhea tables?
🔥 FAIL Shapes languages in all GF glyphsets.
🔥 FAIL Check Google Fonts glyph coverage.
Use -F or --full-lists to disable shortening of long lists. [code: missing-codepoints]
|
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 4 | 6 | 52 | 10 | 180 | 0 |
0% | 0% | 2% | 2% | 21% | 4% | 71% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
This is a deliberately minimal subset (A-Za-z0-9), and we are OK with that. This explains most of the FB FAILs. |
@simoncozens I merged it and then remembered this fails.
After a quick revision to the |
It's fine, the way the average is calculated is confused by these small glyphsets. |
But the And the second FAIL is complaining about the mismatch :) |
Working on the tagging effort, I've noticed the first Edu family merged as a benchmark included the We had agreed on a unified naming strategy, in which case this font should be updated accordingly. |
Currently |
What about this? |
I've fixed the above. However, inspecting this again, similar to the Arrows-Guides variant the figures need to include the arrows. ![]() It needs to be updated to unblock it. cc @EbenSorkin |
I didn't get to this lost night before I fell asleep but I think I will
today.
…-e.
On Tue, Aug 20, 2024 at 6:21 PM Viviana Monsalve ***@***.***> wrote:
Currently display_name: "Edu AU VIC WA NT Hand Arrows" Should be display_name:
"Edu Australia VIC WA NT Hand Arrows"
I've fixed the above. However, inspecting this again, similar to the Arrows-Guides
variant
<#7873 (comment)> the
figures need to include the arrows.
Screenshot.2024-08-20.at.17.14.45.png (view on web)
<https://github.com/user-attachments/assets/8e4c9f50-b3b1-4d45-b6a5-6c3b79a8ae57>
It needs to updated to unblock it.
cc @EbenSorkin <https://github.com/EbenSorkin>
—
Reply to this email directly, view it on GitHub
<#7447 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQUQXPYNKZA5JB3DII3EATZSO6NNAVCNFSM6AAAAABE7NRO5WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJZHA2TQNRSHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Arrows Guide version is almost ready (some menu issues need to be solved). #7873 |
This would be best, yes. I've confirmed it's already blocked. |
Taken from the upstream repo https://github.com/SorkinType/VICWANTSchoolHandAustralia at commit SorkinType/VICWANTSchoolhandAustralia@abab94d.
PR Checklist: