-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jacquarda Bastarda 9 Charted: Version 1.000; ttfautohint (v1.8.4.7-5d5b) added #7084
Jacquarda Bastarda 9 Charted: Version 1.000; ttfautohint (v1.8.4.7-5d5b) added #7084
Conversation
FontBakery reportfontbakery version: 0.10.6 [1] Experimental checks🔥 FAIL: Shapes languages in all GF glyphsets. (com.google.fonts/check/glyphsets/shape_languages)
[code: failed-language-shaping] [1] Family checksℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
[21] JacquardaBastarda9Charted-Regular.ttf🔥 FAIL: Check font follows the Google Fonts vertical metric schema (com.google.fonts/check/vertical_metrics)
🔥 FAIL: Checking OS/2 usWinAscent & usWinDescent. (com.google.fonts/check/family/win_ascent_and_descent)
🔥 FAIL: Whitespace glyphs have ink? (com.google.fonts/check/whitespace_ink)
⚠ WARN: Checking OS/2 achVendID. (com.google.fonts/check/vendor_id)
⚠ WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
Use -F or --full-lists to disable shortening of long lists. Or you can add the above codepoints to one of the subsets supported by the font: ⚠ WARN: Ensure files are not too large. (com.google.fonts/check/file_size)
⚠ WARN: Combined length of family and style must not exceed 27 characters. (com.google.fonts/check/name/family_and_style_max_length)
Please take a look at the conversation at fonttools/fontbakery#2179 in order to understand the reasoning behind these name table records max-length criteria. [code: too-long] ⚠ WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
Use -F or --full-lists to disable shortening of long lists. ⚠ WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
The following glyphs do not have the recommended number of contours:
Use -F or --full-lists to disable shortening of long lists. ⚠ WARN: Check accent of Lcaron, dcaron, lcaron, tcaron (derived from com.google.fonts/check/alt_caron) (com.google.fonts/check/alt_caron)
⚠ WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
⚠ WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
The dot of soft dotted characters should disappear in other cases, for example: ĩ ĭ i̇ ǐ i̒ ĩ̦ ĭ̦ i̦̇ i̦̊ i̦̋ ǐ̦ i̦̒ ĩ̧ ĭ̧ i̧̇ i̧̊ i̧̋ ǐ̧ i̧̒ ĵ Your font fully covers the following languages that require the soft-dotted feature: Lithuanian (Latn, 2,357,094 speakers). Your font does not cover the following languages that require the soft-dotted feature: Dutch (Latn, 31,709,104 speakers), Mango (Latn, 77,000 speakers), Zapotec (Latn, 490,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Navajo (Latn, 166,319 speakers), Dan (Latn, 1,099,244 speakers), Nzakara (Latn, 50,000 speakers), Sar (Latn, 500,000 speakers), Ebira (Latn, 2,200,000 speakers), Fur (Latn, 1,230,163 speakers), Koonzime (Latn, 40,000 speakers), Ejagham (Latn, 120,000 speakers), Lugbara (Latn, 2,200,000 speakers), Igbo (Latn, 27,823,640 speakers), Kom (Latn, 360,685 speakers), South Central Banda (Latn, 244,000 speakers), Aghem (Latn, 38,843 speakers), Basaa (Latn, 332,940 speakers), Bafut (Latn, 158,146 speakers), Belarusian (Cyrl, 10,064,517 speakers), Nateni (Latn, 100,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Ma’di (Latn, 584,000 speakers), Gulay (Latn, 250,478 speakers), Avokaya (Latn, 100,000 speakers). [code: soft-dotted] ℹ INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
PPM <= 65535: ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
Summary
Note: The following loglevels were omitted in this report:
|
…tohint (v1.8.4.7-5d5b) added * Jacquarda Bastarda 9 Charted Version 1.000; ttfautohint (v1.8.4.7-5d5b) taken from the upstream repo https://github.com/scfried/soft-type-jacquarda-bastarda at commit scfried/soft-type-jacquarda-bastarda@cfc133e.
Updated Jacquarda Bastarda 9 Charted: Version 1.000; ttfautohint (v1.8.4.7-5d5b) addedfd72fe7: [gftools-packager] Jacquarda Bastarda 9 Charted: Version 1.000; ttfautohint (v1.8.4.7-5d5b) added
e32fd3e: description and metadatas updated |
7119758
to
e32fd3e
Compare
FontBakery reportfontbakery version: 0.10.9 [1] Experimental checks🔥 FAIL: Shapes languages in all GF glyphsets. (com.google.fonts/check/glyphsets/shape_languages)
[code: failed-language-shaping] [1] Family checksℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
[21] JacquardaBastarda9Charted-Regular.ttf🔥 FAIL: Does DESCRIPTION file contain broken links? (com.google.fonts/check/description/broken_links)
🔥 FAIL: Check OFL body text is correct. (com.google.fonts/check/license/OFL_body_text)
🔥 FAIL: Check copyright namerecords match license file. (com.google.fonts/check/name/license)
🔥 FAIL: Whitespace glyphs have ink? (com.google.fonts/check/whitespace_ink)
⚠ WARN: Checking OS/2 achVendID. (com.google.fonts/check/vendor_id)
⚠ WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
Use -F or --full-lists to disable shortening of long lists. Or you can add the above codepoints to one of the subsets supported by the font: ⚠ WARN: Ensure files are not too large. (com.google.fonts/check/file_size)
⚠ WARN: Combined length of family and style must not exceed 31 characters. (com.google.fonts/check/name/family_and_style_max_length)
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
Use -F or --full-lists to disable shortening of long lists. ⚠ WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
The following glyphs do not have the recommended number of contours:
Use -F or --full-lists to disable shortening of long lists. ⚠ WARN: Check accent of Lcaron, dcaron, lcaron, tcaron (derived from com.google.fonts/check/alt_caron) (com.google.fonts/check/alt_caron)
⚠ WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
⚠ WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
The dot of soft dotted characters should disappear in other cases, for example: ĩ ĭ i̇ ǐ i̒ ĩ̦ ĭ̦ i̦̇ i̦̊ i̦̋ ǐ̦ i̦̒ ĩ̧ ĭ̧ i̧̇ i̧̊ i̧̋ ǐ̧ i̧̒ ĵ Your font fully covers the following languages that require the soft-dotted feature: Lithuanian (Latn, 2,357,094 speakers). Your font does not cover the following languages that require the soft-dotted feature: Igbo (Latn, 27,823,640 speakers), South Central Banda (Latn, 244,000 speakers), Kom (Latn, 360,685 speakers), Koonzime (Latn, 40,000 speakers), Nzakara (Latn, 50,000 speakers), Ebira (Latn, 2,200,000 speakers), Dan (Latn, 1,099,244 speakers), Mango (Latn, 77,000 speakers), Navajo (Latn, 166,319 speakers), Basaa (Latn, 332,940 speakers), Avokaya (Latn, 100,000 speakers), Makaa (Latn, 221,000 speakers), Ma’di (Latn, 584,000 speakers), Belarusian (Cyrl, 10,064,517 speakers), Bafut (Latn, 158,146 speakers), Ejagham (Latn, 120,000 speakers), Dii (Latn, 71,000 speakers), Aghem (Latn, 38,843 speakers), Bete-Bendi (Latn, 100,000 speakers), Fur (Latn, 1,230,163 speakers), Southern Kisi (Latn, 360,000 speakers), Ekpeye (Latn, 226,000 speakers), Zapotec (Latn, 490,000 speakers), Gulay (Latn, 250,478 speakers), Dutch (Latn, 31,709,104 speakers), Mundani (Latn, 34,000 speakers), Ngbaka (Latn, 1,020,000 speakers), Cicipu (Latn, 44,000 speakers), Yala (Latn, 200,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Nateni (Latn, 100,000 speakers), Sar (Latn, 500,000 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Lugbara (Latn, 2,200,000 speakers), Mfumte (Latn, 79,000 speakers). [code: soft-dotted] ℹ INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
PPM <= 65535: ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
Summary
Note: The following loglevels were omitted in this report:
|
@vv-monsalve description updated, the non-charted version looks good in the sandbox, I think we can merge this PR :) |
This comment was marked as outdated.
This comment was marked as outdated.
FontBakery reportfontbakery version: 0.11.1 Checks with FATAL resultsThese must be addressed first. [1] JacquardaBastarda9Charted-Regular.ttf☠ FATAL: The font has tags in the GF Tags spreadsheet (com.google.fonts/check/metadata/has_tags)
All other checks[1] Family checksℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
[20] JacquardaBastarda9Charted-Regular.ttf💔 ERROR: Shapes languages in all GF glyphsets. (com.google.fonts/check/glyphsets/shape_languages)
File "/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/fontbakery/checkrunner.py", line 170, in _exec_check
|
We need to solve the tagging to unblock the merge |
@chrissimpkins are the menus ok? |
Ready! |
9b2bf63: [gftools-packager] Jacquarda Bastarda 9 Charted: Version 1.000; ttfautohint (v1.8.4.7-5d5b) added
7119758: Description and metadatas