Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jacquarda Bastarda 9 Charted: Version 1.000; ttfautohint (v1.8.4.7-5d5b) added #7084

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

emmamarichal
Copy link
Collaborator

9b2bf63: [gftools-packager] Jacquarda Bastarda 9 Charted: Version 1.000; ttfautohint (v1.8.4.7-5d5b) added

7119758: Description and metadatas

@emmamarichal emmamarichal linked an issue Dec 8, 2023 that may be closed by this pull request
9 tasks
Copy link

github-actions bot commented Dec 8, 2023

FontBakery report

fontbakery version: 0.10.6

[1] Experimental checks
🔥 FAIL: Shapes languages in all GF glyphsets. (com.google.fonts/check/glyphsets/shape_languages)
  • 🔥 FAIL GF_Latin_Core glyphset:
Language FAIL messages
gn_Latn (Guarani) Some base glyphs were missing: ʼ
^ Shaper didn't attach tildecomb to E
^ Shaper didn't attach tildecomb to Y
^ Shaper didn't attach tildecomb to u
^ Shaper didn't attach tildecomb to g
^ Shaper didn't attach tildecomb to y
^ Shaper produced a .notdef
nl_Latn (Dutch) Shaper didn't attach acutecomb to J
^ Shaper didn't attach acutecomb to j
qu_Latn (Quechua) Some base glyphs were missing: CHʼ, Kʼ, Pʼ, Qʼ, Tʼ, chʼ, kʼ, pʼ, qʼ, tʼ
^ Shaper produced a .notdef
ro_Latn (Romanian) in Romanian, S-cedilla should become S-comma-accent; both buffers returned Scedilla=0+800

[code: failed-language-shaping]


[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 1 of them (100.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    [code: summary]


[21] JacquardaBastarda9Charted-Regular.ttf
🔥 FAIL: Check font follows the Google Fonts vertical metric schema (com.google.fonts/check/vertical_metrics)
  • 🔥 FAIL The sum of hhea.ascender + abs(hhea.descender) + hhea.lineGap is 1200 when it should be at least 1248 [code: bad-hhea-range]
🔥 FAIL: Checking OS/2 usWinAscent & usWinDescent. (com.google.fonts/check/family/win_ascent_and_descent)
  • 🔥 FAIL OS/2.usWinAscent value should be equal or greater than 1040, but got 960 instead [code: ascent]
  • 🔥 FAIL OS/2.usWinDescent value should be equal or greater than 320, but got 240 instead [code: descent]
🔥 FAIL: Whitespace glyphs have ink? (com.google.fonts/check/whitespace_ink)
  • 🔥 FAIL Glyph 'space' has ink. It needs to be replaced by an empty glyph. [code: has-ink]
  • 🔥 FAIL Glyph 'uni00A0' has ink. It needs to be replaced by an empty glyph. [code: has-ink]
  • 🔥 FAIL Glyph 'uni200A' has ink. It needs to be replaced by an empty glyph. [code: has-ink]
WARN: Checking OS/2 achVendID. (com.google.fonts/check/vendor_id)
  • WARN OS/2 VendorID value 'NONE' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx
    [code: unknown]
WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: yi, canadian-aboriginal, tifinagh

  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi

  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi

  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi

  • U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition

  • U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh

  • U+030A COMBINING RING ABOVE: try adding syriac

  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee

  • U+030C COMBINING CARON: try adding one of: cherokee, tai-le

  • U+0312 COMBINING TURNED COMMA ABOVE: not included in any glyphset definition
    4 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, math, menu, symbols [code: unreachable-subsetting]

WARN: Ensure files are not too large. (com.google.fonts/check/file_size)
  • WARN Font file is 1.7Mb; ideally it should be less than 1.0Mb [code: large-font]
WARN: Combined length of family and style must not exceed 27 characters. (com.google.fonts/check/name/family_and_style_max_length)
  • WARN The combined length of family and style exceeds 27 chars in the following 'WINDOWS' entries:
    FONT_FAMILY_NAME = 'Jacquarda Bastarda 9 Charted' / SUBFAMILY_NAME = 'Regular'

Please take a look at the conversation at fonttools/fontbakery#2179 in order to understand the reasoning behind these name table records max-length criteria. [code: too-long]

WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
  • WARN It seems that Sarah Cadigan-Fried is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • acutecomb.case

    • gravecomb.case

    • i.loclTRK

    • periodcentered.loclCAT

    • periodcentered.loclCAT.case

    • pixel

    • tildecomb.case

    • uni004A0301

    • uni006A0301

    • uni0302.case

    • 8 more.

Use -F or --full-lists to disable shortening of long lists.
[code: unreachable-glyphs]

WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
  • WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: space	Contours detected: 61	Expected: 0

- Glyph name: exclam	Contours detected: 37	Expected: 2

- Glyph name: quotedbl	Contours detected: 43	Expected: 2

- Glyph name: numbersign	Contours detected: 112	Expected: 2

- Glyph name: dollar	Contours detected: 74	Expected: 1, 3 or 5

- Glyph name: percent	Contours detected: 93	Expected: 5

- Glyph name: ampersand	Contours detected: 88	Expected: 1, 2 or 3

- Glyph name: quotesingle	Contours detected: 16	Expected: 1

- Glyph name: parenleft	Contours detected: 37	Expected: 1

- Glyph name: parenright	Contours detected: 40	Expected: 1

- 635 more.

Use -F or --full-lists to disable shortening of long lists.
[code: contour-count]

WARN: Check accent of Lcaron, dcaron, lcaron, tcaron (derived from com.google.fonts/check/alt_caron) (com.google.fonts/check/alt_caron)
  • WARN Lcaron is decomposed and therefore could not be checked. Please check manually. [code: decomposed-outline]
  • WARN dcaron is decomposed and therefore could not be checked. Please check manually. [code: decomposed-outline]
  • WARN lcaron is decomposed and therefore could not be checked. Please check manually. [code: decomposed-outline]
  • WARN tcaron is decomposed and therefore could not be checked. Please check manually. [code: decomposed-outline]
WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
  • WARN No dotted circle glyph present [code: missing-dotted-circle]
WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
  • WARN The dot of soft dotted characters used in orthographies must disappear in the following strings: i̊ i̋ j̀ j́ j̃ j̄ j̈ į̀ į́ į̂ į̃ į̄ į̌

The dot of soft dotted characters should disappear in other cases, for example: ĩ ĭ i̇ ǐ i̒ ĩ̦ ĭ̦ i̦̇ i̦̊ i̦̋ ǐ̦ i̦̒ ĩ̧ ĭ̧ i̧̇ i̧̊ i̧̋ ǐ̧ i̧̒ ĵ

Your font fully covers the following languages that require the soft-dotted feature: Lithuanian (Latn, 2,357,094 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Dutch (Latn, 31,709,104 speakers), Mango (Latn, 77,000 speakers), Zapotec (Latn, 490,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Navajo (Latn, 166,319 speakers), Dan (Latn, 1,099,244 speakers), Nzakara (Latn, 50,000 speakers), Sar (Latn, 500,000 speakers), Ebira (Latn, 2,200,000 speakers), Fur (Latn, 1,230,163 speakers), Koonzime (Latn, 40,000 speakers), Ejagham (Latn, 120,000 speakers), Lugbara (Latn, 2,200,000 speakers), Igbo (Latn, 27,823,640 speakers), Kom (Latn, 360,685 speakers), South Central Banda (Latn, 244,000 speakers), Aghem (Latn, 38,843 speakers), Basaa (Latn, 332,940 speakers), Bafut (Latn, 158,146 speakers), Belarusian (Cyrl, 10,064,517 speakers), Nateni (Latn, 100,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Ma’di (Latn, 584,000 speakers), Gulay (Latn, 250,478 speakers), Avokaya (Latn, 100,000 speakers). [code: soft-dotted]

INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/jacquardabastarda9charted/JacquardaBastarda9Charted-Regular.ttf
Dehinted Size 329.3kb
Hinted Size 1.7Mb
Increase 1.4Mb
Change 434.1 %
[code: size-impact]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 1.000; ttfautohint (v1.8.4.7-5d5b)"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • cvt

    • fpgm

    • loca

    • prep

    • GPOS

    • gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/jacquardabastarda9charted [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 4 11 67 8 165 0
0% 2% 4% 26% 3% 65% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@emmamarichal emmamarichal added the -- Needs Upstream Resolution Upstream fix required before moving forward label Dec 15, 2023
@emmamarichal emmamarichal removed a link to an issue Jan 18, 2024
9 tasks
@emmamarichal emmamarichal linked an issue Jan 18, 2024 that may be closed by this pull request
9 tasks
…tohint (v1.8.4.7-5d5b) added

* Jacquarda Bastarda 9 Charted Version 1.000; ttfautohint (v1.8.4.7-5d5b) taken from the upstream repo https://github.com/scfried/soft-type-jacquarda-bastarda at commit scfried/soft-type-jacquarda-bastarda@cfc133e.
@emmamarichal
Copy link
Collaborator Author

Updated

Jacquarda Bastarda 9 Charted: Version 1.000; ttfautohint (v1.8.4.7-5d5b) added


fd72fe7: [gftools-packager] Jacquarda Bastarda 9 Charted: Version 1.000; ttfautohint (v1.8.4.7-5d5b) added

e32fd3e: description and metadatas updated

@emmamarichal emmamarichal force-pushed the gftools_packager_ofl_jacquardabastarda9charted branch from 7119758 to e32fd3e Compare January 25, 2024 13:48
@emmamarichal emmamarichal removed the -- Needs Upstream Resolution Upstream fix required before moving forward label Jan 25, 2024
Copy link

FontBakery report

fontbakery version: 0.10.9

[1] Experimental checks
🔥 FAIL: Shapes languages in all GF glyphsets. (com.google.fonts/check/glyphsets/shape_languages)
  • 🔥 FAIL GF_Latin_Core glyphset:
Language FAIL messages
nl_Latn (Dutch) Shaper didn't attach acutecomb to j
^ Shaper didn't attach acutecomb to J
ro_Latn (Romanian) in Romanian, S-cedilla should become S-comma-accent; both buffers returned Scedilla=0+800

[code: failed-language-shaping]


[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 1 of them (100.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    [code: summary]


[21] JacquardaBastarda9Charted-Regular.ttf
🔥 FAIL: Does DESCRIPTION file contain broken links? (com.google.fonts/check/description/broken_links)
🔥 FAIL: Check OFL body text is correct. (com.google.fonts/check/license/OFL_body_text)
🔥 FAIL: Check copyright namerecords match license file. (com.google.fonts/check/name/license)
  • 🔥 FAIL License file OFL.txt exists but NameID 13 (LICENSE DESCRIPTION) value on platform 3 (WINDOWS) is not specified for that. Value was: "This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is available with a FAQ at: https://openfontlicense.org" Must be changed to "This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is available with a FAQ at: https://scripts.sil.org/OFL" [code: wrong]
🔥 FAIL: Whitespace glyphs have ink? (com.google.fonts/check/whitespace_ink)
  • 🔥 FAIL Glyph 'space' has ink. It needs to be replaced by an empty glyph. [code: has-ink]
  • 🔥 FAIL Glyph 'uni00A0' has ink. It needs to be replaced by an empty glyph. [code: has-ink]
  • 🔥 FAIL Glyph 'uni200A' has ink. It needs to be replaced by an empty glyph. [code: has-ink]
WARN: Checking OS/2 achVendID. (com.google.fonts/check/vendor_id)
  • WARN OS/2 VendorID value 'NONE' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx
    [code: unknown]
WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: canadian-aboriginal, yi, tifinagh

  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi

  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi

  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi

  • U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition

  • U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh

  • U+030A COMBINING RING ABOVE: try adding syriac

  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee

  • U+030C COMBINING CARON: try adding one of: tai-le, cherokee

  • U+0312 COMBINING TURNED COMMA ABOVE: not included in any glyphset definition
    4 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, math, menu, symbols [code: unreachable-subsetting]

WARN: Ensure files are not too large. (com.google.fonts/check/file_size)
  • WARN Font file is 2.1Mb; ideally it should be less than 1.0Mb [code: large-font]
WARN: Combined length of family and style must not exceed 31 characters. (com.google.fonts/check/name/family_and_style_max_length)
  • WARN Name ID 6 'JacquardaBastarda9Charted-Regular' exceeds 27 characters. This has been found to cause problems with PostScript printers, especially on Mac platforms [code: nameid6-too-long]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • acutecomb.case

    • gravecomb.case

    • i.loclTRK

    • periodcentered.loclCAT

    • periodcentered.loclCAT.case

    • pixel

    • tildecomb.case

    • uni004A0301

    • uni006A0301

    • uni0302.case

    • 8 more.

Use -F or --full-lists to disable shortening of long lists.
[code: unreachable-glyphs]

WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
  • WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: space	Contours detected: 69	Expected: 0

- Glyph name: exclam	Contours detected: 43	Expected: 2

- Glyph name: quotedbl	Contours detected: 49	Expected: 2

- Glyph name: numbersign	Contours detected: 130	Expected: 2

- Glyph name: dollar	Contours detected: 86	Expected: 1, 3 or 5

- Glyph name: percent	Contours detected: 107	Expected: 4 or 5

- Glyph name: ampersand	Contours detected: 102	Expected: 1, 2 or 3

- Glyph name: quotesingle	Contours detected: 18	Expected: 1

- Glyph name: parenleft	Contours detected: 43	Expected: 1

- Glyph name: parenright	Contours detected: 46	Expected: 1

- 635 more.

Use -F or --full-lists to disable shortening of long lists.
[code: contour-count]

WARN: Check accent of Lcaron, dcaron, lcaron, tcaron (derived from com.google.fonts/check/alt_caron) (com.google.fonts/check/alt_caron)
  • WARN Lcaron is decomposed and therefore could not be checked. Please check manually. [code: decomposed-outline]
  • WARN dcaron is decomposed and therefore could not be checked. Please check manually. [code: decomposed-outline]
  • WARN lcaron is decomposed and therefore could not be checked. Please check manually. [code: decomposed-outline]
  • WARN tcaron is decomposed and therefore could not be checked. Please check manually. [code: decomposed-outline]
WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
  • WARN No dotted circle glyph present [code: missing-dotted-circle]
WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
  • WARN The dot of soft dotted characters used in orthographies must disappear in the following strings: i̊ i̋ j̀ j́ j̃ j̄ j̈ į̀ į́ į̂ į̃ į̄ į̌

The dot of soft dotted characters should disappear in other cases, for example: ĩ ĭ i̇ ǐ i̒ ĩ̦ ĭ̦ i̦̇ i̦̊ i̦̋ ǐ̦ i̦̒ ĩ̧ ĭ̧ i̧̇ i̧̊ i̧̋ ǐ̧ i̧̒ ĵ

Your font fully covers the following languages that require the soft-dotted feature: Lithuanian (Latn, 2,357,094 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Igbo (Latn, 27,823,640 speakers), South Central Banda (Latn, 244,000 speakers), Kom (Latn, 360,685 speakers), Koonzime (Latn, 40,000 speakers), Nzakara (Latn, 50,000 speakers), Ebira (Latn, 2,200,000 speakers), Dan (Latn, 1,099,244 speakers), Mango (Latn, 77,000 speakers), Navajo (Latn, 166,319 speakers), Basaa (Latn, 332,940 speakers), Avokaya (Latn, 100,000 speakers), Makaa (Latn, 221,000 speakers), Ma’di (Latn, 584,000 speakers), Belarusian (Cyrl, 10,064,517 speakers), Bafut (Latn, 158,146 speakers), Ejagham (Latn, 120,000 speakers), Dii (Latn, 71,000 speakers), Aghem (Latn, 38,843 speakers), Bete-Bendi (Latn, 100,000 speakers), Fur (Latn, 1,230,163 speakers), Southern Kisi (Latn, 360,000 speakers), Ekpeye (Latn, 226,000 speakers), Zapotec (Latn, 490,000 speakers), Gulay (Latn, 250,478 speakers), Dutch (Latn, 31,709,104 speakers), Mundani (Latn, 34,000 speakers), Ngbaka (Latn, 1,020,000 speakers), Cicipu (Latn, 44,000 speakers), Yala (Latn, 200,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Nateni (Latn, 100,000 speakers), Sar (Latn, 500,000 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Lugbara (Latn, 2,200,000 speakers), Mfumte (Latn, 79,000 speakers). [code: soft-dotted]

INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/jacquardabastarda9charted/JacquardaBastarda9Charted-Regular.ttf
Dehinted Size 382.9kb
Hinted Size 2.1Mb
Increase 1.8Mb
Change 470.9 %
[code: size-impact]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 1.000; ttfautohint (v1.8.4.7-5d5b)"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • cvt

    • fpgm

    • loca

    • prep

    • GPOS

    • gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/jacquardabastarda9charted [code: family-path]

Summary

💔 ERROR ☠ FATAL 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 0 5 10 69 8 164 0
0% 0% 2% 4% 27% 3% 64% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@vv-monsalve vv-monsalve marked this pull request as draft January 25, 2024 17:35
@emmamarichal emmamarichal marked this pull request as ready for review February 7, 2024 15:00
@emmamarichal
Copy link
Collaborator Author

@vv-monsalve description updated, the non-charted version looks good in the sandbox, I think we can merge this PR :)

This comment was marked as outdated.

Copy link

github-actions bot commented Feb 7, 2024

FontBakery report

fontbakery version: 0.11.1

Checks with FATAL results

These must be addressed first.

[1] JacquardaBastarda9Charted-Regular.ttf
FATAL: The font has tags in the GF Tags spreadsheet (com.google.fonts/check/metadata/has_tags)
  • FATAL Family does not appear in tag spreadsheet. [code: no-tags]

All other checks

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO All of the fonts lack a STAT table.
    [code: summary]

[20] JacquardaBastarda9Charted-Regular.ttf
💔 ERROR: Shapes languages in all GF glyphsets. (com.google.fonts/check/glyphsets/shape_languages)
  • 💔 ERROR Failed with AttributeError: 'Vharfbuzz' object has no attribute 'ttfont'
  File "/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/fontbakery/checkrunner.py", line 170, in _exec_check
    results.extend(list(result))
  File "/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/fontbakery/profiles/googlefonts.py", line 3537, in com_google_fonts_check_glyphsets_shape_languages
    shaperglot_checker = Checker(ttFont.reader.file.name)
  File "/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/shaperglot/checker.py", line 23, in __init__
    self.ttfont = self.vharfbuzz.ttfont

``` [code: failed-check]
</div></details><details><summary>💔 <b>ERROR:</b> Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (<a href="https://font-bakery.readthedocs.io/en/stable/fontbakery/profiles/Shaping Checks.html#com.google.fonts/check/soft_dotted">com.google.fonts/check/soft_dotted</a>)</summary><div>


* 💔 **ERROR** Failed with AttributeError: 'Vharfbuzz' object has no attribute 'ttfont'

File "/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/fontbakery/checkrunner.py", line 170, in _exec_check
results.extend(list(result))
File "/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/fontbakery/profiles/shaping.py", line 726, in com_google_fonts_check_soft_dotted
checker = Checker(ttFont.reader.file.name)
File "/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/shaperglot/checker.py", line 23, in init
self.ttfont = self.vharfbuzz.ttfont

</div></details><details><summary>🔥 <b>FAIL:</b> Does DESCRIPTION file contain broken links? (<a href="https://font-bakery.readthedocs.io/en/stable/fontbakery/profiles/googlefonts.html#com.google.fonts/check/description/broken_links">com.google.fonts/check/description/broken_links</a>)</summary><div>


* 🔥 **FAIL** The following links are broken in the DESCRIPTION file:
	https://fonts.google.com/specimen/Jacquarda+Bastarda+9 (status code: 404) [code: broken-links]
</div></details><details><summary>🔥 <b>FAIL:</b> Whitespace glyphs have ink? (<a href="https://font-bakery.readthedocs.io/en/stable/fontbakery/profiles/universal.html#com.google.fonts/check/whitespace_ink">com.google.fonts/check/whitespace_ink</a>)</summary><div>


* 🔥 **FAIL** Glyph 'space' has ink. It needs to be replaced by an empty glyph. [code: has-ink]
* 🔥 **FAIL** Glyph 'uni00A0' has ink. It needs to be replaced by an empty glyph. [code: has-ink]
* 🔥 **FAIL** Glyph 'uni200A' has ink. It needs to be replaced by an empty glyph. [code: has-ink]
</div></details><details><summary>⚠ <b>WARN:</b> Checking OS/2 achVendID. (<a href="https://font-bakery.readthedocs.io/en/stable/fontbakery/profiles/googlefonts.html#com.google.fonts/check/vendor_id">com.google.fonts/check/vendor_id</a>)</summary><div>


* ⚠ **WARN** OS/2 VendorID value 'NONE' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx
 [code: unknown]
</div></details><details><summary>⚠ <b>WARN:</b> Check for codepoints not covered by METADATA subsets. (<a href="https://font-bakery.readthedocs.io/en/stable/fontbakery/profiles/googlefonts.html#com.google.fonts/check/metadata/unreachable_subsetting">com.google.fonts/check/metadata/unreachable_subsetting</a>)</summary><div>


* ⚠ **WARN** The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

 * U+0020 SPACE: try adding one of: znamenny, gothic, runic, takri, newa, vai, miao, old-uyghur, caucasian-albanian, gurmukhi, chakma, chorasmian, egyptian-hieroglyphs, masaram-gondi, tagalog, pahawh-hmong, imperial-aramaic, japanese, korean, tai-le, coptic, nag-mundari, cham, mongolian, makasar, medefaidrin, myanmar, yezidi, telugu, linear-b, greek-ext, meroitic-hieroglyphs, sinhala, mayan-numerals, lepcha, armenian, zanabazar-square, braille, thaana, cypro-minoan, ogham, mende-kikakui, malayalam, ahom, vietnamese, psalter-pahlavi, anatolian-hieroglyphs, cyrillic, old-italic, tirhuta, nushu, vithkuqi, shavian, hatran, devanagari, mro, palmyrene, meetei-mayek, phags-pa, old-north-arabian, limbu, nabataean, buhid, mahajani, yi, tai-viet, lydian, tagbanwa, linear-a, adlam, wancho, grantha, bhaiksuki, batak, sundanese, modi, samaritan, hanunoo, tai-tham, sharada, old-south-arabian, siddham, khmer, meroitic, khudawadi, cherokee, kharoshthi, soyombo, sogdian, pau-cin-hau, hanifi-rohingya, signwriting, chinese-hongkong, elbasan, georgian, nyiakeng-puachue-hmong, lycian, inscriptional-pahlavi, music, multani, syloti-nagri, old-turkic, inscriptional-parthian, greek, kaithi, tangsa, cypriot, osage, dogra, phoenician, tifinagh, toto, khitan-small-script, syriac, oriya, osmanya, elymaic, cyrillic-ext, indic-siyaq-numbers, glagolitic, nko, rejang, kawi, meroitic-cursive, arabic, carian, ugaritic, tamil, gunjala-gondi, tamil-supplement, marchen, buginese, javanese, dives-akuru, old-hungarian, ol-chiki, old-sogdian, tibetan, lao, lisu, bengali, kannada, mandaic, canadian-aboriginal, balinese, hebrew, manichaean, sora-sompeng, old-permic, thai, kayah-li, saurashtra, chinese-traditional, new-tai-lue, brahmi, warang-citi, khojki, cuneiform, avestan, ottoman-siyaq-numbers, deseret, tangut, bassa-vah, bamum, chinese-simplified, duployan, nandinagari, old-persian, gujarati, ethiopic
 * U+00A0 NO-BREAK SPACE: try adding one of: znamenny, gothic, runic, takri, newa, vai, miao, old-uyghur, caucasian-albanian, gurmukhi, chakma, chorasmian, egyptian-hieroglyphs, masaram-gondi, tagalog, pahawh-hmong, imperial-aramaic, japanese, korean, tai-le, coptic, nag-mundari, cham, mongolian, makasar, medefaidrin, myanmar, yezidi, telugu, linear-b, greek-ext, meroitic-hieroglyphs, sinhala, mayan-numerals, lepcha, armenian, zanabazar-square, braille, thaana, cypro-minoan, ogham, mende-kikakui, malayalam, ahom, vietnamese, psalter-pahlavi, anatolian-hieroglyphs, cyrillic, old-italic, tirhuta, nushu, vithkuqi, shavian, hatran, devanagari, mro, palmyrene, meetei-mayek, phags-pa, old-north-arabian, limbu, nabataean, buhid, mahajani, yi, tai-viet, lydian, tagbanwa, linear-a, adlam, wancho, grantha, bhaiksuki, batak, sundanese, modi, samaritan, hanunoo, tai-tham, sharada, old-south-arabian, siddham, khmer, meroitic, khudawadi, cherokee, kharoshthi, soyombo, sogdian, pau-cin-hau, hanifi-rohingya, signwriting, chinese-hongkong, elbasan, georgian, nyiakeng-puachue-hmong, lycian, inscriptional-pahlavi, music, multani, syloti-nagri, old-turkic, inscriptional-parthian, greek, kaithi, tangsa, cypriot, osage, dogra, phoenician, tifinagh, toto, khitan-small-script, syriac, oriya, osmanya, elymaic, cyrillic-ext, indic-siyaq-numbers, glagolitic, nko, rejang, kawi, meroitic-cursive, arabic, carian, ugaritic, tamil, gunjala-gondi, tamil-supplement, marchen, buginese, javanese, dives-akuru, old-hungarian, ol-chiki, old-sogdian, tibetan, lao, lisu, bengali, kannada, mandaic, canadian-aboriginal, balinese, hebrew, manichaean, sora-sompeng, old-permic, thai, kayah-li, saurashtra, chinese-traditional, new-tai-lue, brahmi, warang-citi, khojki, cuneiform, avestan, ottoman-siyaq-numbers, deseret, tangut, bassa-vah, bamum, chinese-simplified, duployan, nandinagari, old-persian, gujarati, ethiopic
 * U+02C7 CARON: try adding one of: yi, canadian-aboriginal, tifinagh
 * U+02D8 BREVE: try adding one of: canadian-aboriginal, yi
 * U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
 * U+02DB OGONEK: try adding one of: canadian-aboriginal, yi
 * U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition
 * U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic
 * U+030A COMBINING RING ABOVE: try adding syriac
 * U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage
6 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: `latin`, `latin-ext`, `math`, `menu`, `symbols` [code: unreachable-subsetting]
</div></details><details><summary>⚠ <b>WARN:</b> Ensure files are not too large. (<a href="https://font-bakery.readthedocs.io/en/stable/fontbakery/profiles/googlefonts.html#com.google.fonts/check/file_size">com.google.fonts/check/file_size</a>)</summary><div>


* ⚠ **WARN** Font file is 2.1Mb; ideally it should be less than 1.0Mb [code: large-font]
</div></details><details><summary>⚠ <b>WARN:</b> Combined length of family and style must not exceed 32 characters. (<a href="https://font-bakery.readthedocs.io/en/stable/fontbakery/profiles/googlefonts.html#com.google.fonts/check/name/family_and_style_max_length">com.google.fonts/check/name/family_and_style_max_length</a>)</summary><div>


* ⚠ **WARN** Name ID 6 'JacquardaBastarda9Charted-Regular' exceeds 27 characters. This has been found to cause problems with PostScript printers, especially on Mac platforms. [code: nameid6-too-long]
</div></details><details><summary>⚠ <b>WARN:</b> Ensure fonts have ScriptLangTags declared on the 'meta' table. (<a href="https://font-bakery.readthedocs.io/en/stable/fontbakery/profiles/googlefonts.html#com.google.fonts/check/meta/script_lang_tags">com.google.fonts/check/meta/script_lang_tags</a>)</summary><div>


* ⚠ **WARN** This font file does not have a 'meta' table. [code: lacks-meta-table]
</div></details><details><summary>⚠ <b>WARN:</b> Check font contains no unreachable glyphs (<a href="https://font-bakery.readthedocs.io/en/stable/fontbakery/profiles/universal.html#com.google.fonts/check/unreachable_glyphs">com.google.fonts/check/unreachable_glyphs</a>)</summary><div>


* ⚠ **WARN** The following glyphs could not be reached by codepoint or substitution rules:

	- acutecomb.case

	- gravecomb.case

	- i.loclTRK

	- periodcentered.loclCAT

	- periodcentered.loclCAT.case

	- pixel

	- tildecomb.case

	- uni004A0301

	- uni006A0301

	- uni0302.case

	- 8 more.

Use -F or --full-lists to disable shortening of long lists.
 [code: unreachable-glyphs]
</div></details><details><summary>⚠ <b>WARN:</b> Check if each glyph has the recommended amount of contours. (<a href="https://font-bakery.readthedocs.io/en/stable/fontbakery/profiles/universal.html#com.google.fonts/check/contour_count">com.google.fonts/check/contour_count</a>)</summary><div>


* ⚠ **WARN** This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

	- Glyph name: space	Contours detected: 69	Expected: 0

	- Glyph name: exclam	Contours detected: 43	Expected: 2

	- Glyph name: quotedbl	Contours detected: 49	Expected: 2

	- Glyph name: numbersign	Contours detected: 130	Expected: 2

	- Glyph name: dollar	Contours detected: 86	Expected: 1, 3 or 5

	- Glyph name: percent	Contours detected: 107	Expected: 4 or 5

	- Glyph name: ampersand	Contours detected: 102	Expected: 1, 2 or 3

	- Glyph name: quotesingle	Contours detected: 18	Expected: 1

	- Glyph name: parenleft	Contours detected: 43	Expected: 1

	- Glyph name: parenright	Contours detected: 46	Expected: 1

	- 635 more.

Use -F or --full-lists to disable shortening of long lists.
 [code: contour-count]
</div></details><details><summary>⚠ <b>WARN:</b> Check accent of Lcaron, dcaron, lcaron, tcaron (derived from com.google.fonts/check/alt_caron) (<a href="https://font-bakery.readthedocs.io/en/stable/fontbakery/profiles/universal.html#com.google.fonts/check/alt_caron">com.google.fonts/check/alt_caron</a>)</summary><div>


* ⚠ **WARN** Lcaron is decomposed and therefore could not be checked. Please check manually. [code: decomposed-outline]
* ⚠ **WARN** dcaron is decomposed and therefore could not be checked. Please check manually. [code: decomposed-outline]
* ⚠ **WARN** lcaron is decomposed and therefore could not be checked. Please check manually. [code: decomposed-outline]
* ⚠ **WARN** tcaron is decomposed and therefore could not be checked. Please check manually. [code: decomposed-outline]
</div></details><details><summary>⚠ <b>WARN:</b> Ensure dotted circle glyph is present and can attach marks. (<a href="https://font-bakery.readthedocs.io/en/stable/fontbakery/profiles/Shaping Checks.html#com.google.fonts/check/dotted_circle">com.google.fonts/check/dotted_circle</a>)</summary><div>


* ⚠ **WARN** No dotted circle glyph present [code: missing-dotted-circle]
</div></details><details><summary>ℹ <b>INFO:</b> Does DESCRIPTION file contain a upstream Git repo URL? (<a href="https://font-bakery.readthedocs.io/en/stable/fontbakery/profiles/googlefonts.html#com.google.fonts/check/description/git_url">com.google.fonts/check/description/git_url</a>)</summary><div>


* ℹ **INFO** Found a git repo URL: https://github.com/scfried/soft-type-jacquarda-bastarda [code: url-found]
</div></details><details><summary>ℹ <b>INFO:</b> Show hinting filesize impact. (<a href="https://font-bakery.readthedocs.io/en/stable/fontbakery/profiles/googlefonts.html#com.google.fonts/check/hinting_impact">com.google.fonts/check/hinting_impact</a>)</summary><div>


* ℹ **INFO** Hinting filesize impact:

 |               | ofl/jacquardabastarda9charted/JacquardaBastarda9Charted-Regular.ttf          |
 |:------------- | ---------------:|
 | Dehinted Size | 382.9kb |
 | Hinted Size   | 2.1Mb   |
 | Increase      | 1.8Mb      |
 | Change        | 470.9 %  |
 [code: size-impact]
</div></details><details><summary>ℹ <b>INFO:</b> EPAR table present in font? (<a href="https://font-bakery.readthedocs.io/en/stable/fontbakery/profiles/googlefonts.html#com.google.fonts/check/epar">com.google.fonts/check/epar</a>)</summary><div>


* ℹ **INFO** EPAR table not present in font. To learn more see https://github.com/fonttools/fontbakery/issues/818 [code: lacks-EPAR]
</div></details><details><summary>ℹ <b>INFO:</b> Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (<a href="https://font-bakery.readthedocs.io/en/stable/fontbakery/profiles/googlefonts.html#com.google.fonts/check/gasp">com.google.fonts/check/gasp</a>)</summary><div>


* ℹ **INFO** These are the ppm ranges declared on the gasp table:

PPM <= 65535:
	flag = 0x0F
	- Use grid-fitting
	- Use grayscale rendering
	- Use gridfitting with ClearType symmetric smoothing
	- Use smoothing along multiple axes with ClearType®
 [code: ranges]
</div></details><details><summary>ℹ <b>INFO:</b> Check for font-v versioning. (<a href="https://font-bakery.readthedocs.io/en/stable/fontbakery/profiles/googlefonts.html#com.google.fonts/check/fontv">com.google.fonts/check/fontv</a>)</summary><div>


* ℹ **INFO** Version string is: "Version 1.000; ttfautohint (v1.8.4.7-5d5b)"
The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
"Version 1.3; git-0d08353-release" [code: bad-format]
</div></details><details><summary>ℹ <b>INFO:</b> Font contains all required tables? (<a href="https://font-bakery.readthedocs.io/en/stable/fontbakery/profiles/universal.html#com.google.fonts/check/required_tables">com.google.fonts/check/required_tables</a>)</summary><div>


* ℹ **INFO** This font contains the following optional tables:

	- cvt 

	- fpgm

	- loca

	- prep

	- GPOS

	- gasp [code: optional-tables]
</div></details><details><summary>ℹ <b>INFO:</b> List all superfamily filepaths (<a href="https://font-bakery.readthedocs.io/en/stable/fontbakery/profiles/universal.html#com.google.fonts/check/superfamily/list">com.google.fonts/check/superfamily/list</a>)</summary><div>


* ℹ **INFO** ofl/jacquardabastarda9charted [code: family-path]
</div></details><br></div></details>

### Summary

| 💔 ERROR | ☠ FATAL | 🔥 FAIL | ⚠ WARN | 💤 SKIP | ℹ INFO | 🍞 PASS | 🔎 DEBUG |
|:-----:|:-----:|:-----:|:-----:|:-----:|:-----:|:-----:|:-----:|
| 2 | 1 | 2 | 9 | 68 | 8 | 170 | 0 |
| 1% | 0% | 1% | 3% | 26% | 3% | 65% | 0% |

**Note:** The following loglevels were omitted in this report:
* **SKIP**
* **PASS**
* **DEBUG**

@vv-monsalve
Copy link
Collaborator

We need to solve the tagging to unblock the merge

@emmamarichal emmamarichal merged commit cd4680a into main Feb 21, 2024
8 of 9 checks passed
@emmamarichal emmamarichal deleted the gftools_packager_ofl_jacquardabastarda9charted branch February 21, 2024 13:04
@emmamarichal
Copy link
Collaborator Author

@chrissimpkins are the menus ok?

@chrissimpkins
Copy link
Collaborator

@chrissimpkins are the menus ok?

Ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Live
Development

Successfully merging this pull request may close these issues.

Add Soft Type Jacquarda Bastarda 9 Charted
3 participants