Noto Sans PhagsPa: Version 2.004; ttfautohint (v1.8.4.7-5d5b) added #7049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…8.4.7-5d5b) added * Noto Sans PhagsPa Version 2.004; ttfautohint (v1.8.4.7-5d5b) taken from the upstream repo https://github.com/notofonts/phags-pa.git at commit https://github.com/notofonts/phags-pa/commit/.
FontBakery reportfontbakery version: 0.10.4 [1] Experimental checks🔥 FAIL: Shapes languages in all GF glyphsets. (com.google.fonts/check/glyphsets/shape_languages)
[code: failed-language-shaping]
[code: warning-language-shaping] [1] Family checksℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
[18] NotoSansPhagsPa-Regular.ttf💔 ERROR: Check METADATA.pb includes production subsets. (com.google.fonts/check/metadata/includes_production_subsets)
🔥 FAIL: Check that legacy accents aren't used in composite glyphs. (derived from com.google.fonts/check/legacy_accents) (com.google.fonts/check/legacy_accents)
⚠ WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
Use -F or --full-lists to disable shortening of long lists. Or you can add the above codepoints to one of the subsets supported by the font: ⚠ WARN: Glyphs are similiar to Google Fonts version? (com.google.fonts/check/production_glyphs_similarity)
⚠ WARN: On a family update, the DESCRIPTION.en_us.html file should ideally also be updated. (com.google.fonts/check/description/family_update)
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
⚠ WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
The following glyphs do not have the recommended number of contours: [code: contour-count] ⚠ WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
Width = 322: ⚠ WARN: Are there any misaligned on-curve points? (com.google.fonts/check/outline_alignment_miss)
Use -F or --full-lists to disable shortening of long lists. [code: found-misalignments] ⚠ WARN: Are any segments inordinately short? (com.google.fonts/check/outline_short_segments)
Use -F or --full-lists to disable shortening of long lists. [code: found-short-segments] ⚠ WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
The dot of soft dotted characters should disappear in other cases, for example: į̆ į̇ į̈ į̊ į̋ į̒ į̦̀ į̦́ į̦̂ į̦̃ į̦̄ į̦̆ į̦̇ į̦̈ į̦̊ į̦̋ į̦̌ į̦̒ į̧̀ į̧́ Your font fully covers the following languages that require the soft-dotted feature: Lithuanian (Latn, 2,357,094 speakers), Dutch (Latn, 31,709,104 speakers). Your font does not cover the following languages that require the soft-dotted feature: Mango (Latn, 77,000 speakers), Sar (Latn, 500,000 speakers), Avokaya (Latn, 100,000 speakers), Dan (Latn, 1,099,244 speakers), Kom (Latn, 360,685 speakers), Koonzime (Latn, 40,000 speakers), Aghem (Latn, 38,843 speakers), Lugbara (Latn, 2,200,000 speakers), Igbo (Latn, 27,823,640 speakers), Gulay (Latn, 250,478 speakers), Ejagham (Latn, 120,000 speakers), Ma’di (Latn, 584,000 speakers), Nateni (Latn, 100,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Ebira (Latn, 2,200,000 speakers), Belarusian (Cyrl, 10,064,517 speakers), Navajo (Latn, 166,319 speakers), Basaa (Latn, 332,940 speakers). [code: soft-dotted] ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
PPM <= 65535: ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
Summary
Note: The following loglevels were omitted in this report:
|
RosaWagner
reviewed
Dec 5, 2023
FontBakery reportfontbakery version: 0.10.6 [1] Experimental checks🔥 FAIL: Shapes languages in all GF glyphsets. (com.google.fonts/check/glyphsets/shape_languages)
[code: failed-language-shaping] [1] Family checksℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
[18] NotoSansPhagsPa-Regular.ttf💔 ERROR: Check METADATA.pb includes production subsets. (com.google.fonts/check/metadata/includes_production_subsets)
🔥 FAIL: Check that legacy accents aren't used in composite glyphs. (derived from com.google.fonts/check/legacy_accents) (com.google.fonts/check/legacy_accents)
⚠ WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
Use -F or --full-lists to disable shortening of long lists. Or you can add the above codepoints to one of the subsets supported by the font: ⚠ WARN: Glyphs are similiar to Google Fonts version? (com.google.fonts/check/production_glyphs_similarity)
⚠ WARN: On a family update, the DESCRIPTION.en_us.html file should ideally also be updated. (com.google.fonts/check/description/family_update)
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
⚠ WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
The following glyphs do not have the recommended number of contours: [code: contour-count] ⚠ WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
Width = 322: ⚠ WARN: Are there any misaligned on-curve points? (com.google.fonts/check/outline_alignment_miss)
Use -F or --full-lists to disable shortening of long lists. [code: found-misalignments] ⚠ WARN: Are any segments inordinately short? (com.google.fonts/check/outline_short_segments)
Use -F or --full-lists to disable shortening of long lists. [code: found-short-segments] ⚠ WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
The dot of soft dotted characters should disappear in other cases, for example: į̆ į̇ į̈ į̊ į̋ į̒ į̦̀ į̦́ į̦̂ į̦̃ į̦̄ į̦̆ į̦̇ į̦̈ į̦̊ į̦̋ į̦̌ į̦̒ į̧̀ į̧́ Your font fully covers the following languages that require the soft-dotted feature: Lithuanian (Latn, 2,357,094 speakers), Dutch (Latn, 31,709,104 speakers). Your font does not cover the following languages that require the soft-dotted feature: Gulay (Latn, 250,478 speakers), Nzakara (Latn, 50,000 speakers), Igbo (Latn, 27,823,640 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Sar (Latn, 500,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Mango (Latn, 77,000 speakers), Koonzime (Latn, 40,000 speakers), Zapotec (Latn, 490,000 speakers), Aghem (Latn, 38,843 speakers), Nateni (Latn, 100,000 speakers), Ejagham (Latn, 120,000 speakers), Lugbara (Latn, 2,200,000 speakers), Navajo (Latn, 166,319 speakers), Kom (Latn, 360,685 speakers), Basaa (Latn, 332,940 speakers), Bafut (Latn, 158,146 speakers), Avokaya (Latn, 100,000 speakers), South Central Banda (Latn, 244,000 speakers), Ma’di (Latn, 584,000 speakers), Dan (Latn, 1,099,244 speakers), Fur (Latn, 1,230,163 speakers), Ebira (Latn, 2,200,000 speakers), Belarusian (Cyrl, 10,064,517 speakers). [code: soft-dotted] ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
PPM <= 65535: ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
Summary
Note: The following loglevels were omitted in this report:
|
|
@vv-monsalve @emmamarichal @eliheuer @m4rc1e there is an important naming situation here that might create confusion in the servers. We had a font which It is a bit similar as this family which changed name #5609. Previous PR was introducing a new name and a new directory ( Since the So here the new PR allows to:
We can check in dev-sandbox once merged if it creates 2 families or 2 URLs as I suspect. If yes we need to inform the eng team about the trickiness of the situation. Either they delist the additional URL, either they ask us to revert the change in the |
RosaWagner
added
-- Needs confirmation
|
The family looks good in dev, and I see only one family appearing. Although the 2 URLs exist so the old one, so Noto+Sans+Phags+Pa needs to be delisted. |
|
Also Nko had a similar issue, iir |
vv-monsalve
added
-- Needs Eng team opinion
This is included in the delist list. We are waiting for the delist to land to unblock this PR. |
|
@nathan-williams This is the other case where we need the delist to happen to unblock this landing into production :)
Dev server |
|
Bringing @nathan-williams chat answer here:
So, I'm unblocking this PR now to allow this font to reach prod. |
vv-monsalve
removed
the
-- Needs Eng team opinion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dc92351: [gftools-packager] Noto Sans PhagsPa: Version 2.004; ttfautohint (v1.8.4.7-5d5b) added