-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playpen: Emoji subset added to metadata #7032
Conversation
FontBakery reportfontbakery version: 0.10.4 [1] Experimental checks🔥 FAIL: Shapes languages in all GF glyphsets. (com.google.fonts/check/glyphsets/shape_languages)
[code: failed-language-shaping]
[code: warning-language-shaping] [1] Family checksℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
[14] PlaypenSans[wght].ttf🔥 FAIL: Check for METADATA subsets with zero support. (com.google.fonts/check/metadata/unsupported_subsets)
🔥 FAIL: Check METADATA.pb includes production subsets. (com.google.fonts/check/metadata/includes_production_subsets)
⚠ WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
Use -F or --full-lists to disable shortening of long lists. Or you can add the above codepoints to one of the subsets supported by the font: ⚠ WARN: Check if category on METADATA.pb matches what can be inferred from the family name. (com.google.fonts/check/metadata/category_hints)
⚠ WARN: Does the font contain a soft hyphen? (com.google.fonts/check/soft_hyphen)
⚠ WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
Your font fully covers the following languages that require the soft-dotted feature: Dutch (Latn, 31,709,104 speakers), Ma’di (Latn, 584,000 speakers), Ebira (Latn, 2,200,000 speakers), Igbo (Latn, 27,823,640 speakers), Navajo (Latn, 166,319 speakers), Lithuanian (Latn, 2,357,094 speakers). Your font does not cover the following languages that require the soft-dotted feature: Kom (Latn, 360,685 speakers), Dan (Latn, 1,099,244 speakers), Mango (Latn, 77,000 speakers), Sar (Latn, 500,000 speakers), Aghem (Latn, 38,843 speakers), Basaa (Latn, 332,940 speakers), Gulay (Latn, 250,478 speakers), Nateni (Latn, 100,000 speakers), Belarusian (Cyrl, 10,064,517 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Ejagham (Latn, 120,000 speakers), Avokaya (Latn, 100,000 speakers), Koonzime (Latn, 40,000 speakers), Lugbara (Latn, 2,200,000 speakers). [code: soft-dotted] ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
ℹ INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
PPM <= 65535: ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
ℹ INFO: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
Summary
Note: The following loglevels were omitted in this report:
|
@vv-monsalve Can't we include symbols and emoji? I am thinking of the arrows or other codepoints that could be related to symbols |
(I usually add the proper label to know what this PR is about, and then remove from the project board manually if another PR is already tracked) |
I accidentally merged the metadata PR before finishing reading your comments. I had the doubt about deleting "Symbols". I'll reinstate it in another PR. |
Actually, checking at the font again the codepoints that would require "symbols" are the same ones that would be covered by "emoji". |
This PR is being tracked through production here: #7041 |
Changing subset
symbols
toemoji
to #7006.@RosaWagner The PR updating the font was merged this morning. In cases like these small quick fixes, should we add the
METADATA
label to this PR in any case?Edit: Not adding labels to only track the changes through the font's PR linked above.