Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kumbh Sans: Version 1.005 added #7028

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Conversation

RosaWagner
Copy link
Contributor

4bd526b: [gftools-packager] Kumbh Sans: Version 1.005 added

@RosaWagner
Copy link
Contributor Author

Expected changes for this release:

  • fixes some interpolation issues
  • fixes the lack of anchors/automatic alignments etc. Most accented letters were decomposed and accents placed manually. Therefore we expect some shifts in the diacritic positions. All accepted by author here: Fixed some other mark fails xconsau/KumbhSans#16 (comment)

@RosaWagner RosaWagner added I Small Fix bugs fixed but nothing added III Improve rendering / layout by addition of manual hinting, kerning or else labels Nov 29, 2023
@RosaWagner RosaWagner linked an issue Nov 29, 2023 that may be closed by this pull request
Copy link

FontBakery report

fontbakery version: 0.10.4

[1] Experimental checks
🔥 FAIL: Shapes languages in all GF glyphsets. (com.google.fonts/check/glyphsets/shape_languages)
  • 🔥 FAIL GF_Latin_Core glyphset:
Language FAIL messages
br_Latn (Breton) Some base glyphs were missing: CʼH, cʼh
^ Shaper produced a .notdef
haw_Latn (Hawaiian) Some base glyphs were missing: ʻ
^ Shaper produced a .notdef
mh_Latn (Marshallese) Some base glyphs were missing: Ḷ, ḷ, Ṃ, ṃ, Ṇ, ṇ, Ọ, ọ
^ Some mark glyphs were missing: ◌̣
^ Shaper produced a .notdef
qu_Latn (Quechua) Some base glyphs were missing: CHʼ, Kʼ, Pʼ, Qʼ, Tʼ, chʼ, kʼ, pʼ, qʼ, tʼ
^ Shaper produced a .notdef
scn_Latn (Sicilian) Some base glyphs were missing: Ḍ, ḍ
^ Shaper produced a .notdef
teo_Latn (Teso) Some base glyphs were missing: Ɔ, Ɛ, Ɨ, Ʉ, ɔ, ɛ, ɨ, ʉ, ᵃ, ᵉ, ᵋ, ᵒ, ᵓ, ᵘ, ᶤ, ᶶ, ⁱ
^ Shaper produced a .notdef

[code: failed-language-shaping]

  • WARN GF_Latin_Core glyphset:
Language FAIL messages
lg_Latn (Ganda) No variant glyphs were found for Eng
dyo_Latn (Jola-Fonyi) No variant glyphs were found for Eng
ny_Latn (Nyanja) No variant glyphs were found for Eng
wo_Latn (Wolof) No variant glyphs were found for Eng

[code: warning-language-shaping]


[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    ('YOPQ-wght', 1) [code: summary]


[21] KumbhSans[YOPQ,wght].ttf
🔥 FAIL: Validate defaults on fvar table match registered fallback names in GFAxisRegistry. (com.google.fonts/check/gf_axisregistry/fvar_axis_defaults)
  • 🔥 FAIL The defaul value YOPQ:300.0 is not registered as an axis fallback name on the Google Axis Registry.
    You should consider suggesting the addition of this value to the registry or adopted one of the existing fallback names for this axis:
    [name: "Normal"
    value: 116.0
    ] [code: not-registered]
🔥 FAIL: Validate STAT particle names and values match the fallback names in GFAxisRegistry. (com.google.fonts/check/STAT/gf_axisregistry)
  • 🔥 FAIL Axis Value for 'YOPQ':'Normal' is expected to be '116.0' but this font has 'Normal'='300.0'. [code: bad-coordinate]
WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: tifinagh, canadian-aboriginal, yi

  • U+02C9 MODIFIER LETTER MACRON: not included in any glyphset definition

  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi

  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi

  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi

  • U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition

  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic

  • U+030A COMBINING RING ABOVE: try adding syriac

  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee

  • U+030C COMBINING CARON: try adding one of: tai-le, cherokee
    12 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, math, menu, symbols [code: unreachable-subsetting]

WARN: Glyphs are similiar to Google Fonts version? (com.google.fonts/check/production_glyphs_similarity)
  • WARN Following glyphs differ greatly from Google Fonts version:
    • I
    • Iacute
    • Icircumflex
    • Idieresis
    • Idotaccent
    • Igrave
    • Imacron
    • Iogonek
    • Itilde
    • Racute and 3 more.

Use -F or --full-lists to disable shortening of long lists.

WARN: Are there caret positions declared for every ligature? (com.google.fonts/check/ligature_carets)
  • WARN This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]
WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
  • WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + f

    • f + i

    • i + f

    • f + l

    • l + f

    • i + l

    • longs + t [code: lacks-kern-info]

WARN: Ensure variable fonts include an avar table. (com.google.fonts/check/mandatory_avar_table)
  • WARN This variable font does not have an avar table. [code: missing-avar]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Does the font contain a soft hyphen? (com.google.fonts/check/soft_hyphen)
  • WARN This font has a 'Soft Hyphen' character. [code: softhyphen]
WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
  • WARN The most common width is 1144 among a set of 2 math glyphs.
    The following math glyphs have a different width, though:

Width = 1166:
less, greater

Width = 1265:
equal, notequal

Width = 1099:
logicalnot

Width = 1006:
multiply

Width = 1110:
divide, minus

Width = 1352:
approxequal

Width = 1247:
greaterequal, lessequal
[code: width-outliers]

WARN: Check accent of Lcaron, dcaron, lcaron, tcaron (derived from com.google.fonts/check/alt_caron) (com.google.fonts/check/alt_caron)
  • WARN Lcaron is decomposed and therefore could not be checked. Please check manually. [code: decomposed-outline]
  • WARN dcaron is decomposed and therefore could not be checked. Please check manually. [code: decomposed-outline]
  • WARN lcaron is decomposed and therefore could not be checked. Please check manually. [code: decomposed-outline]
  • WARN tcaron is decomposed and therefore could not be checked. Please check manually. [code: decomposed-outline]
WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
  • WARN No dotted circle glyph present [code: missing-dotted-circle]
WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
  • WARN The dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌

The dot of soft dotted characters should disappear in other cases, for example: i̒ i̦̒ i̧̒ j̒ j̦̒ j̧̒ j̨̒ į̆ į̇ į̈ į̊ į̋ į̒ į̦̀ į̦́ į̦̂ į̦̃ į̦̄ į̦̆ į̦̇

Your font fully covers the following languages that require the soft-dotted feature: Lithuanian (Latn, 2,357,094 speakers), Dutch (Latn, 31,709,104 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Kom (Latn, 360,685 speakers), Nateni (Latn, 100,000 speakers), Ma’di (Latn, 584,000 speakers), Ebira (Latn, 2,200,000 speakers), Dan (Latn, 1,099,244 speakers), Lugbara (Latn, 2,200,000 speakers), Ejagham (Latn, 120,000 speakers), Igbo (Latn, 27,823,640 speakers), Belarusian (Cyrl, 10,064,517 speakers), Gulay (Latn, 250,478 speakers), Koonzime (Latn, 40,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Sar (Latn, 500,000 speakers), Avokaya (Latn, 100,000 speakers), Navajo (Latn, 166,319 speakers), Mango (Latn, 77,000 speakers), Basaa (Latn, 332,940 speakers), Aghem (Latn, 38,843 speakers). [code: soft-dotted]

INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/kumbhsans/KumbhSans[YOPQ,wght].ttf
Dehinted Size 116.0kb
Hinted Size 116.0kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.005'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 1.005"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/kumbhsans [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 3 11 44 9 188 0
0% 1% 4% 17% 4% 74% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@vv-monsalve
Copy link
Collaborator

LGTM

@vv-monsalve vv-monsalve merged commit 739bf7a into main Dec 5, 2023
9 checks passed
@vv-monsalve vv-monsalve deleted the gftools_packager_ofl_kumbhsans branch December 5, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I Small Fix bugs fixed but nothing added III Improve rendering / layout by addition of manual hinting, kerning or else
Projects
Status: Live
Development

Successfully merging this pull request may close these issues.

Update Kumbh Sans
2 participants