Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alike Angular: Version 1.300; ttfautohint (v1.8.4.7-5d5b) added #6930

Merged
merged 4 commits into from
Nov 15, 2023
Merged

Alike Angular: Version 1.300; ttfautohint (v1.8.4.7-5d5b) added #6930

merged 4 commits into from
Nov 15, 2023

Conversation

emmamarichal
Copy link
Collaborator

ba0196b: [gftools-packager] Alike Angular: Version 1.300; ttfautohint (v1.8.4.7-5d5b) added

5e0ef9c: description updated

ee06dc0: deleted fontlog

@emmamarichal
Copy link
Collaborator Author

Same question as here: #6929 (comment)

@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@emmamarichal emmamarichal added the -- Needs Meta/Desc/License changes Corrections in METADATA.pb or html snippet or License file required label Nov 2, 2023
@RosaWagner RosaWagner mentioned this pull request Nov 2, 2023
Closed
@github-actions GitHub Actions
Copy link

FontBakery report

fontbakery version: 0.10.3

[1] Experimental checks
🔥 FAIL: Shapes languages in all GF glyphsets. (com.google.fonts/check/glyphsets/shape_languages)
  • 🔥 FAIL GF_Latin_Core/br_Latn (Breton): [FAIL: Some base glyphs were missing: cʼh, FAIL: Shaper produced a .notdef] [code: failed-language-shaping]
  • 🔥 FAIL GF_Latin_Core/nl_Latn (Dutch): [FAIL: Shaper didn't attach acutecomb to uni0237] [code: failed-language-shaping]
  • 🔥 FAIL GF_Latin_Core/haw_Latn (Hawaiian): [FAIL: Some base glyphs were missing: ʻ, FAIL: Shaper produced a .notdef] [code: failed-language-shaping]
  • 🔥 FAIL GF_Latin_Core/mh_Latn (Marshallese): [FAIL: Some base glyphs were missing: Ḷ, ḷ, Ṃ, ṃ, Ṇ, ṇ, Ọ, ọ, FAIL: Some mark glyphs were missing: ◌̣, FAIL: Shaper produced a .notdef] [code: failed-language-shaping]
  • 🔥 FAIL GF_Latin_Core/qu_Latn (Quechua): [FAIL: Some base glyphs were missing: chʼ, kʼ, pʼ, qʼ, tʼ, FAIL: Shaper produced a .notdef] [code: failed-language-shaping]
  • 🔥 FAIL GF_Latin_Core/scn_Latn (Sicilian): [FAIL: Some base glyphs were missing: Ḍ, ḍ, FAIL: Shaper produced a .notdef] [code: failed-language-shaping]
  • 🔥 FAIL GF_Latin_Core/teo_Latn (Teso): [FAIL: Some base glyphs were missing: Ɔ, Ɛ, Ɨ, Ʉ, ɔ, ɛ, ɨ, ʉ, ᵃ, ᵉ, ᵋ, ᵒ, ᵓ, ᵘ, ᶤ, ᶶ, ⁱ, FAIL: Shaper produced a .notdef] [code: failed-language-shaping]
  • ⚠ WARN GF_Latin_Core/lg_Latn (Ganda): [WARN: No variant glyphs were found for Eng] [code: warning-language-shaping]
  • ⚠ WARN GF_Latin_Core/dyo_Latn (Jola-Fonyi): [WARN: No variant glyphs were found for Eng] [code: warning-language-shaping]
  • ⚠ WARN GF_Latin_Core/ny_Latn (Nyanja): [WARN: No variant glyphs were found for Eng] [code: warning-language-shaping]
  • ⚠ WARN GF_Latin_Core/wo_Latn (Wolof): [WARN: No variant glyphs were found for Eng] [code: warning-language-shaping]

[1] Family checks
ℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)

  • ℹ INFO From a total of 1 font files, 1 of them (100.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    [code: summary]


[21] AlikeAngular-Regular.ttf
🔥 FAIL: Ensure METADATA.pb does not use escaped strings. (com.google.fonts/check/metadata/escaped_strings)
  • 🔥 FAIL Found escaped chars at 'Copyright 2009 The Alike Angular Project Authors (https://github.com/cyrealtype/Alike-Angular) with Reserved Font Name '. Please use an unicode string instead. [code: escaped-strings]
⚠ WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)

  • ⚠ WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: tifinagh, canadian-aboriginal, yi

  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi

  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi

  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi

  • U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition

  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic

  • U+030A COMBINING RING ABOVE: try adding syriac

  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage

  • U+030C COMBINING CARON: try adding one of: cherokee, tai-le

  • U+0312 COMBINING TURNED COMMA ABOVE: not included in any glyphset definition
    3 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, math, menu, symbols [code: unreachable-subsetting]

⚠ WARN: Copyright notice on METADATA.pb should not contain 'Reserved Font Name'. (com.google.fonts/check/metadata/reserved_font_name)
  • ⚠ WARN METADATA.pb: copyright field ("Copyright 2009 The Alike Angular Project Authors (https://github.com/cyrealtype/Alike-Angular) with Reserved Font Name "Alike" and "Alike Angular".") contains "Reserved Font Name". This is an error except in a few specific rare cases. [code: rfn]
⚠ WARN: Glyphs are similiar to Google Fonts version? (com.google.fonts/check/production_glyphs_similarity)
  • ⚠ WARN Following glyphs differ greatly from Google Fonts version:
    • .notdef
    • exclamdown and macron
⚠ WARN: Name table strings must not contain the string 'Reserved Font Name'. (com.google.fonts/check/name/rfn)
  • ⚠ WARN Name table entry contains "Reserved Font Name" for a family name ("Alike" and "Alike Angular") that differs from the currently used family name (AlikeAngular), which is fine. [code: legacy-familyname]
⚠ WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
  • ⚠ WARN It seems that Sveta Sebyakina is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • ⚠ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)

  • ⚠ WARN The following glyphs could not be reached by codepoint or substitution rules:

    • foundryicon

    • noBreak

    • nonmarkingreturn
      [code: unreachable-glyphs]

⚠ WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
  • ⚠ WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: aogonek	Contours detected: 3	Expected: 2

- Glyph name: eogonek	Contours detected: 3	Expected: 2

- Glyph name: Uogonek	Contours detected: 2	Expected: 1

- Glyph name: uogonek	Contours detected: 2	Expected: 1

- Glyph name: Uogonek	Contours detected: 2	Expected: 1

- Glyph name: aogonek	Contours detected: 3	Expected: 2

- Glyph name: eogonek	Contours detected: 3	Expected: 2

- Glyph name: uogonek	Contours detected: 2	Expected: 1

[code: contour-count]

⚠ WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
  • ⚠ WARN The most common width is 541 among a set of 3 math glyphs.
    The following math glyphs have a different width, though:

Width = 485:
plus

Width = 542:
equal

Width = 624:
logicalnot

Width = 514:
plusminus

Width = 445:
multiply

Width = 504:
divide
[code: width-outliers]

⚠ WARN: Are there any misaligned on-curve points? (com.google.fonts/check/outline_alignment_miss)

  • ⚠ WARN The following glyphs have on-curve points which have potentially incorrect y coordinates:

    • quotedbl (U+0022): X=203.0,Y=707.0 (should be at cap-height 705?)

    • quotedbl (U+0022): X=303.0,Y=707.0 (should be at cap-height 705?)

    • quotedbl (U+0022): X=46.0,Y=707.0 (should be at cap-height 705?)

    • quotedbl (U+0022): X=146.0,Y=707.0 (should be at cap-height 705?)

    • dollar (U+0024): X=257.0,Y=707.0 (should be at cap-height 705?)

    • dollar (U+0024): X=316.0,Y=706.0 (should be at cap-height 705?)

    • percent (U+0025): X=545.0,Y=706.0 (should be at cap-height 705?)

    • ampersand (U+0026): X=608.0,Y=-1.0 (should be at baseline 0?)

    • quotesingle (U+0027): X=46.0,Y=707.0 (should be at cap-height 705?)

    • quotesingle (U+0027): X=146.0,Y=707.0 (should be at cap-height 705?)

    • 88 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-misalignments]

⚠ WARN: Do outlines contain any semi-vertical or semi-horizontal lines? (com.google.fonts/check/outline_semi_vertical)

  • ⚠ WARN The following glyphs have semi-vertical/semi-horizontal lines:

    • F (U+0046): L<<533.0,661.0>--<532.0,530.0>>

    • IJ (U+0132): L<<454.0,108.0>--<456.0,538.0>>

    • J (U+004A): L<<115.0,108.0>--<117.0,538.0>>

    • OE (U+0152): L<<430.0,666.0>--<306.0,665.0>>

    • S (U+0053): L<<455.0,661.0>--<456.0,530.0>>

    • Sacute (U+015A): L<<455.0,661.0>--<456.0,530.0>>

    • Scaron (U+0160): L<<455.0,661.0>--<456.0,530.0>>

    • Scedilla (U+015E): L<<455.0,661.0>--<456.0,530.0>>

    • a (U+0061): L<<408.0,396.0>--<409.0,182.0>>

    • aacute (U+00E1): L<<408.0,396.0>--<409.0,182.0>>

    • 63 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-semi-vertical]

⚠ WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
  • ⚠ WARN No dotted circle glyph present [code: missing-dotted-circle]
⚠ WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
  • ⚠ WARN The dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌

The dot of soft dotted characters should disappear in other cases, for example: į̆ į̇ į̈ į̊ į̋ į̒ į̦̀ į̦́ į̦̂ į̦̃ į̦̄ į̦̆ į̦̇ į̦̈ į̦̊ į̦̋ į̦̌ į̦̒ į̧̀ į̧́

Your font fully covers the following languages that require the soft-dotted feature: Lithuanian (Latn, 2,357,094 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Aghem (Latn, 38,843 speakers), Dan (Latn, 1,099,244 speakers), Dutch (Latn, 31,709,104 speakers), Kom (Latn, 360,685 speakers), Nateni (Latn, 100,000 speakers), Basaa (Latn, 332,940 speakers), Lugbara (Latn, 2,200,000 speakers), Ebira (Latn, 2,200,000 speakers), Belarusian (Cyrl, 10,064,517 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Igbo (Latn, 27,823,640 speakers), Koonzime (Latn, 40,000 speakers), Ejagham (Latn, 120,000 speakers), Avokaya (Latn, 100,000 speakers), Ma’di (Latn, 584,000 speakers), Navajo (Latn, 166,319 speakers). [code: soft-dotted]

ℹ INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • ℹ INFO Hinting filesize impact:
ofl/alikeangular/AlikeAngular-Regular.ttf
Dehinted Size 45.7kb
Hinted Size 60.7kb
Increase 15.0kb
Change 32.8 %
[code: size-impact]
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • ℹ INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • ℹ INFO Version string is: "Version 1.300; ttfautohint (v1.8.4.7-5d5b)"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)

  • ℹ INFO This font contains the following optional tables:

    • cvt

    • fpgm

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp [code: optional-tables]

ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • ℹ INFO ofl/alikeangular [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 2 13 62 8 170 0
0% 1% 5% 24% 3% 67% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@emmamarichal
Copy link
Collaborator Author

@felipesanches fyi!

I deleted a space character in the linebreak in description, to avoid that fail:

⚠ WARN: DESCRIPTION.en_us.html should end in a linebreak. ([com.google.fonts/check/description/eof_linebreak](https://font-bakery.readthedocs.io/en/stable/fontbakery/profiles/googlefonts.html#com.google.fonts/check/description/eof_linebreak))

The fail is well gone, but this change also removed that fail, even though they're not really related:

🔥 FAIL: METADATA.pb: Check URL on copyright string is the same as in repository_url field. ([com.google.fonts/check/metadata/consistent_repo_urls](https://font-bakery.readthedocs.io/en/stable/fontbakery/profiles/googlefonts.html#com.google.fonts/check/metadata/consistent_repo_urls))

@emmamarichal
Copy link
Collaborator Author

I never know what is the good way to write it, can someone show me?

🔥 FAIL: Ensure METADATA.pb does not use escaped strings. (com.google.fonts/check/metadata/escaped_strings)

@RosaWagner RosaWagner removed the -- Needs confirmation from upstream or onboarder label Nov 14, 2023
@m4rc1e m4rc1e mentioned this pull request Nov 14, 2023
Open
@vv-monsalve
Copy link
Collaborator

🔥 FAIL: Shapes languages in all GF glyphsets.

The misleading support was reported in Fontbakery issue #4322

@RosaWagner RosaWagner merged commit b4dabc1 into main Nov 15, 2023
@RosaWagner RosaWagner deleted the gftools_packager_ofl_alikeangular branch November 15, 2023 12:57
@RosaWagner RosaWagner removed the -- Needs Meta/Desc/License changes Corrections in METADATA.pb or html snippet or License file required label Nov 15, 2023
@RosaWagner RosaWagner linked an issue Nov 15, 2023 that may be closed by this pull request
Update Alike Angular #6839
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RosaWagner RosaWagner RosaWagner approved these changes

@vv-monsalve vv-monsalve vv-monsalve approved these changes

Assignees
No one assigned
Labels
I Font Upgrade
Projects
Fonts Traffic Jam
Status: Live
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Alike Angular
3 participants
@emmamarichal @vv-monsalve @RosaWagner