Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User feedback on Edu VIC WA NT Beginner: "the flicks on the letters are not correct" #7871

Closed
rokapoz opened this issue Jun 17, 2024 · 14 comments
Assignees

Comments

@rokapoz
Copy link
Collaborator

rokapoz commented Jun 17, 2024

Listnr report:

"
This is a great font, and I use it regularly as it is the closest on Google Docs to Victorian Cursive. However for it to match the Victorian Cursive the flicks on the letters are not correct, many are missing and the cross bars on I and J are also incorrect. See this link https://www.education.vic.gov.au/Documents/school/teachers/teachingresources/discipline/english/alphabetmodela.pdf
I'm not sure if you can update it to better represent the victorian font.
"

@chrissimpkins
Copy link
Collaborator

@EbenSorkin Mind having a look at this bug report to see if this requires design revisions? This is an anonymous user report that came in through our front end. We won't be able to seek additional clarifications. They are anonymous reports.

@EbenSorkin
Copy link
Collaborator

EbenSorkin commented Jun 20, 2024 via email

@emmamarichal
Copy link
Collaborator

@EbenSorkin @simoncozens, I let you open an issue in the upstream repo, if some revisions are needed here. I close this one for now!
thanks!

@EbenSorkin
Copy link
Collaborator

EbenSorkin commented Jun 25, 2024 via email

@vv-monsalve
Copy link
Collaborator

Confirming: So, should the recently merged #7628 be blocked for now and updated before proceeding further in the pipeline?

@EbenSorkin
Copy link
Collaborator

EbenSorkin commented Jun 25, 2024 via email

@vv-monsalve
Copy link
Collaborator

If you will address it now (today) and include it in all subsequent Edu VIC PRs, I think this one should be updated before, for consistency's sake.

@simoncozens
Copy link
Collaborator

Wait a minute. This is Edu VIC WA NT Beginner, not Edu VIC WA NT Hand. Different family.

@vv-monsalve
Copy link
Collaborator

Ough! The name structure within this wide range of Edu families makes them a bit confusing or difficult to differentiate! :')
Okay, these changes would not apply to any current PRs, right?

@EbenSorkin
Copy link
Collaborator

EbenSorkin commented Jun 26, 2024 via email

@simoncozens
Copy link
Collaborator

The Hand families (https://github.com/SorkinType/VICWANTSchoolHandAustralia) produce multiple fonts from the same source, but they do not produce Edu VIC WA NT Beginner. This font comes from completely separate sources (https://github.com/MezMerrit/AU-School-Handwriting-Fonts), and we onboarded it some time ago.

This issue might actually apply to both sets of handwriting families - I haven't checked - but I want to be clear that the reporter is talking about the Beginner font which is already in prod.

@vv-monsalve
Copy link
Collaborator

vv-monsalve commented Jun 26, 2024

This is a one-source-to-many build so it would apply to that source but

It was from this understanding that I made the question. Beginners is one of the previous families in prod for a long time now. But, when Eben said he would apply the changes, I understood he was referring to the current source files, hence the question.

This issue might actually apply to both sets of handwriting families - I haven't checked

If this is the case, we should be sure that any change that gets incorporated now and if it applies to the recently merged family it should receive also.

@simoncozens
Copy link
Collaborator

OK, I have reviewed this again. The crossbars on I and J are incorrect and should be removed from both families. The model that the user is referring to is for the Cursive and Precursive variants, so it is correct that the "Beginner" family and the "Hand" apex family do not have the "flicks"; the Cursive and Precursive variants of Edu VIC WA NT Hand do contain the correct flicks. So all we need to do is drop the crossbars (and respace). I will do this.

@vv-monsalve
Copy link
Collaborator

vv-monsalve commented Jul 16, 2024

So, confirming to be clear, will you update both #7628 and, eventually, the currently distributed Edu VIC WA NT Beginner font?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants