-
Notifications
You must be signed in to change notification settings - Fork 124
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix PyCLIF-C-API codegen bug for
@extend
@classmethod
(b/334753945).
Support for `@extend` `@classmethod` was added with cl/331177628. The bug fixed by this CL was introduced with cl/333112933 in Sep 2020. Manual testing using this command: ``` blaze test --config=asan third_party/clif/testing/python:extend_classmethods_test ``` * With the new test code but WITHOUT the change in clif/python/gen.py: http://sponge2/c9071f9f-d4df-4e42-88a8-02619b814418 (failed) ``` SUMMARY: UndefinedBehaviorSanitizer: signed-integer-overflow third_party/clif/testing/python/extend_classmethods_clif_aux.h:22:29 ``` * With this CL as mailed: http://sponge2/4e335657-ff83-4300-ae4d-0b68003346e5 (passed) * With `--//devtools/clif/python/codegen_mode=pybind11`: http://sponge2/f765d23c-caed-4402-921c-eae64b122068 (passed) PiperOrigin-RevId: 625564244
- Loading branch information
Showing
4 changed files
with
28 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters