Skip to content

Commit

Permalink
[symupload] Log details to stderr on failure
Browse files Browse the repository at this point in the history
On success, symupload emits details such as the debug identifier. Emit a
very similar message to stderr on failure, as this information may also
be useful when diagnosing upload failures.

Bug: chromium:349736158
Change-Id: Ic3b5316283e4603dca815bd85a2fd51516fbcca8
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5682842
Reviewed-by: Ivan Penkov <ivanpe@chromium.org>
  • Loading branch information
GregTho authored and Ivan Penkov committed Jul 8, 2024
1 parent 5b748cb commit 2c5ac8a
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions src/tools/windows/symupload/symupload.cc
Original file line number Diff line number Diff line change
Expand Up @@ -305,12 +305,12 @@ int wmain(int argc, wchar_t* argv[]) {

_wunlink(symbol_file.c_str());

if (success) {
wprintf(L"Uploaded breakpad symbols for windows-%s/%s/%s (%s %s)\n",
pdb_info.cpu.c_str(), pdb_info.debug_file.c_str(),
pdb_info.debug_identifier.c_str(), code_file.c_str(),
file_version.c_str());
}
fwprintf(success ? stdout : stderr,
L"%S breakpad symbols for windows-%s/%s/%s (%s %s)\n",
success ? "Uploaded" : "Failed to upload",
pdb_info.cpu.c_str(), pdb_info.debug_file.c_str(),
pdb_info.debug_identifier.c_str(), code_file.c_str(),
file_version.c_str());

return success ? 0 : 1;
}

0 comments on commit 2c5ac8a

Please sign in to comment.