Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Presenting of UIAlertViewController inside ToolboxCategoryViewController #311

Open
vicng opened this issue Feb 3, 2017 · 0 comments
Open
Labels

Comments

@vicng
Copy link
Contributor

vicng commented Feb 3, 2017

A UIAlertViewController is being presented by ToolboxCategoryViewController#workspaceViewController, but this causes an Xcode warning:

Presenting view controllers on detached view controllers is discouraged <BKYWorkspaceViewController: 0x7fd914412920>.

Couple of things need to be fixed here:

  1. Call addChildViewController(workspaceViewController) on ToolboxCategoryViewController
  2. WorkbenchViewController needs to be refactored so it can manage presenting this popover. It currently has special state checks which automatically dismiss popovers unless it's aware of them. (Note: this isn't current behavior, but once Re-added support for CocoaPods/Carthage after changing repos. Updated… #1 is fixed, the workbench will cause automatic dismissing of the alert view.)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant