CppRef<T> changes. #1463
Merged
CppRef<T> changes. #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes were made as part of the prototyping for use of the new arbitrary self types v2 Rust feature (#1429) but are worth promoting into main even before that's landed. Some tweaks: * We no longer depend on the `arbitrary_self_types_pointers` nightly feature but instead just `arbitrary_self_types`. * CppRef<T> no longer has an associated lifetime. Instead there's a separate CppLtRef<T> type.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes were made as part of the prototyping for use of the new arbitrary self types v2 Rust feature (#1429) but are worth promoting into main even before that's landed.
Some tweaks:
arbitrary_self_types_pointersnightly feature but instead justarbitrary_self_types.