Reorganize encoding.py so it doesn't rely on imports in __init__.py #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarrisonGregg
force-pushed
the
reorganize-encoding
branch
3 times, most recently
from
fa0d130 to
51b7e41
Compare
|
Travis build is failing: https://travis-ci.org/google/apitools/builds/392441331?utm_source=github_status&utm_medium=notification. |
HarrisonGregg
force-pushed
the
reorganize-encoding
branch
2 times, most recently
from
94889db to
a43a899
Compare
vilasj
approved these changes
Jun 15, 2018
HarrisonGregg
force-pushed
the
reorganize-encoding
branch
8 times, most recently
from
2aeb767 to
d020d7c
Compare
HarrisonGregg
force-pushed
the
reorganize-encoding
branch
from
d020d7c to
3845f73
Compare
sixolet
pushed a commit
to sixolet/apitools
that referenced
this pull request
Aug 7, 2018
…oogle#234) * Move functionality in encoding.py to encoding_helper.py * Add encoding.py file that imports encoding_helper and extra_types
sixolet
pushed a commit
to sixolet/apitools
that referenced
this pull request
Aug 7, 2018
…oogle#234) * Move functionality in encoding.py to encoding_helper.py * Add encoding.py file that imports encoding_helper and extra_types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite for addressing #232.
Currently, when you import
apitools.base.py.encoding, it triggers the imports inapitools/base/py/__init__.py. This includes importingextra_types.py, which makes patches toencoding, such as:That means that if you remove the imports in
__init__.py, thenencodingbehaves differently becauseextra_typesisn't imported. This change reorganizesencoding.py, so that whenever it is imported,extra_types.pyis also imported.