Composition #888
Open
Composition #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sferrogoo
requested review from
Databean,
rmuthiah,
jemoreira and
ser-io
as code owners
|
@sferrogoo, to sync your branch with latest changes, please use |
jemoreira
reviewed
Feb 28, 2025
| @@ -86,6 +86,7 @@ message Display { | |||
| optional uint32 height = 2; | |||
| optional uint32 dpi = 3; | |||
| optional uint32 refresh_rate_hertz = 4; | |||
| optional string overlays = 5; | |||
There was a problem hiding this comment.
Use a strongly typed message here, maybe something similar to what's in launch_cvd.proto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change coincides with aosp/3502986
Note this is the 'MVP' version of feature. There are plans to enhance the feature with more robust configuration via planned v1 implementation, outlined at: go/cf_display_composition_dd