Reorganize physics package. #785
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_732272746
branch
4 times, most recently
from
73e4f23 to
26ba5a9
Compare
Previously, various physics calculations which were not directly associated with an existing component like sources, transport_models, were dispersed between physics.py and post_processing.py. This refactor introduces a physics package and clearer organization of physics functions into thematic modules: collisions, charge_states, psi_calculations, and scaling_laws. Drive-by: cleanup of unnecessary comments and docstring fixes Upcoming PR will move "physics" calculations from post_processing into the physics package. PiperOrigin-RevId: 732272746
copybara-service
bot
force-pushed
the
test_732272746
branch
from
26ba5a9 to
83dbbc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganize physics package.
Previously, various physics calculations which were not directly associated with an existing component like sources, transport_models, were dispersed between physics.py and post_processing.py.
This refactor introduces a physics package and clearer organization of physics functions into thematic modules: collisions, charge_states, psi_calculations, and scaling_laws.
Drive-by: cleanup of unnecessary comments and docstring fixes
Upcoming PR will move "physics" calculations from post_processing into the physics package.