Update Deep CFR implementations to implement Policy #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `player_id` argument is not need, but still needs to be present in order to implement `Policy`. For example without it `PolicyBot` breaks as it passes three arguments (self, the game state and the player id).
|
Thanks! I am off on vacation at the moment but will take a look when I get back. (Note: the test failure seems unrelated.. cause by a backward incompatibility in numpy the we have to fix) |
|
Great, looking good! 👍 (The test failing is something we have to fix in our side.) |
lanctot
added
imported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
player_idargument is not need, but still needs to be present in order to implementPolicy. For example without it PolicyBot breaks as it passes three arguments (self, the game state and the player id).