Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSpiel 1.5 Preparation: Remove support for Python 3.8 #1195

Merged
merged 3 commits into from
Apr 5, 2024
+4 −20
Merged

OpenSpiel 1.5 Preparation: Remove support for Python 3.8 #1195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
42287d1
Remove support for Python 3.8
lanctot Apr 4, 2024
ddc727e
Update wheels.yml
lanctot Apr 4, 2024
6a7cb2d
Update setup.py
lanctot Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions .github/workflows/actions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,6 @@ jobs:
BUILD_SHARED_LIB: "OFF"
OPEN_SPIEL_BUILD_WITH_ORTOOLS: "OFF"
OPEN_SPIEL_BUILD_WITH_ORTOOLS_DOWNLOAD_URL: ""
# Standard or older platforms with older Python versions.
- os: macos-11
OS_PYTHON_VERSION: "3.8"
TRAVIS_USE_NOX: 0
DEFAULT_OPTIONAL_DEPENDENCY: "OFF"
BUILD_SHARED_LIB: "OFF"
OPEN_SPIEL_BUILD_WITH_ORTOOLS: "OFF"
OPEN_SPIEL_BUILD_WITH_ORTOOLS_DOWNLOAD_URL: ""
# Older Python version on Ubuntu 20.04
- os: ubuntu-20.04
OS_PYTHON_VERSION: "3.9"
Expand All @@ -57,14 +49,6 @@ jobs:
BUILD_SHARED_LIB: "ON"
OPEN_SPIEL_BUILD_WITH_ORTOOLS: "OFF"
OPEN_SPIEL_BUILD_WITH_ORTOOLS_DOWNLOAD_URL: ""
# One older platform with oldest Python version on that platform.
- os: ubuntu-20.04
OS_PYTHON_VERSION: "3.8"
TRAVIS_USE_NOX: 0
DEFAULT_OPTIONAL_DEPENDENCY: "OFF"
BUILD_SHARED_LIB: "OFF"
OPEN_SPIEL_BUILD_WITH_ORTOOLS: "OFF"
OPEN_SPIEL_BUILD_WITH_ORTOOLS_DOWNLOAD_URL: ""

runs-on: ${{ matrix.os }}
env:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/wheels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,13 @@ jobs:
CI_PYBIN: python3
OS_PYTHON_VERSION: 3.10
CIBW_ENVIRONMENT: "CXX=$(which g++) OPEN_SPIEL_BUILDING_WHEEL='ON' OPEN_SPIEL_BUILD_WITH_ACPC='ON' OPEN_SPIEL_BUILD_WITH_HANABI='ON' OPEN_SPIEL_BUILD_WITH_ROSHAMBO='ON'"
CIBW_BUILD: cp38-manylinux_x86_64 cp39-manylinux_x86_64 cp310-manylinux_x86_64 cp311-manylinux_x86_64 cp312-manylinux_x86_64
CIBW_BUILD: cp39-manylinux_x86_64 cp310-manylinux_x86_64 cp311-manylinux_x86_64 cp312-manylinux_x86_64
- os: macOS-12
OS_TYPE: "Darwin"
CI_PYBIN: python3.9
OS_PYTHON_VERSION: 3.9
CIBW_ENVIRONMENT: "OPEN_SPIEL_BUILDING_WHEEL='ON' OPEN_SPIEL_BUILD_WITH_ACPC='ON' OPEN_SPIEL_BUILD_WITH_HANABI='ON' OPEN_SPIEL_BUILD_WITH_ROSHAMBO='ON'"
CIBW_BUILD: cp38-macosx_x86_64 cp39-macosx_x86_64 cp310-macosx_x86_64 cp311-macosx_x86_64 cp312-macosx_x86_64
CIBW_BUILD: cp39-macosx_x86_64 cp310-macosx_x86_64 cp311-macosx_x86_64 cp312-macosx_x86_64
# Setting to the new M1 runners to build the _arm64 wheels
# https://github.blog/2023-10-02-introducing-the-new-apple-silicon-powered-m1-macos-larger-runner-for-github-actions/
# Disabling now that the OpenSpiel 1.4 wheels are on PyPI because these xlarge machines are
Expand Down
4 changes: 2 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ def _parse_line(s):

setuptools.setup(
name="open_spiel",
version="1.4",
version="1.5",
license="Apache 2.0",
author="The OpenSpiel authors",
author_email="open_spiel@google.com",
Expand All @@ -138,7 +138,7 @@ def _parse_line(s):
long_description_content_type="text/markdown",
url="https://github.com/deepmind/open_spiel",
install_requires=_get_requirements(req_file),
python_requires=">=3.8",
python_requires=">=3.9",
ext_modules=[CMakeExtension("pyspiel", sourcedir="open_spiel")],
cmdclass={"build_ext": BuildExt},
zip_safe=False,
Expand Down
Loading