Mike/lstream 654/screenshare audio #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikekanter
force-pushed
the
mike/LSTREAM-654/screenshare-audio
branch
from
19e0aa1 to
f9eacc1
Compare
mikekanter
force-pushed
the
mike/LSTREAM-654/screenshare-audio
branch
from
f9eacc1 to
f849e92
Compare
| @@ -2012,12 +2079,33 @@ export const commands = (_project: ScenelessProject) => { | |||
| }, | |||
| }) | |||
| }, | |||
| setParticipantAudioOnly( | |||
There was a problem hiding this comment.
Currently, calling setParticipantAudioOnly on ScreenShare hides the container and also mutes the audio. Making it visible again does not unmute the audio; it remains muted.
This behavior is consistent across Camera participants as well.
There was a problem hiding this comment.
It works fine for me on stage
There was a problem hiding this comment.
I think this was glitch. It works well now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.