Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for "cargo make build" and "cargo make check" on windows #1266

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

noise64
Copy link
Contributor

@noise64 noise64 commented Jan 24, 2025

Various smaller fixes related to windows to make work cargo make check and cargo make build.

As a temporary solution (until we decide on the soozu dep) this change skips the proxy part of the golem start command, meaning it can be compiled, but won't work. This solution was chosen, because

  • it is not to easy to exclude some projects based on platfrom
  • at least some parts are still checked for compile on win, until we find a better solution.
  • requries no special action / exclude to be done by developers on windows

NOTE: it seem i had to decrease cargo jobs to 12 to make it reliable work with 32 GB (maybe more also can work, will test it later)

@noise64 noise64 merged commit a6f0729 into main Jan 27, 2025
19 checks passed
@noise64 noise64 deleted the win-cleanups branch January 27, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants