Defined the DurabilityHost interface and migrated Durability to it #1236
Conversation
| pub struct PersistedDurableFunctionInvocation { | ||
| timestamp: Timestamp, | ||
| function_name: String, | ||
| response: Vec<u8>, |
There was a problem hiding this comment.
It might make sense to not load the response by default but instead allow streaming them in when needed. I believe we can have quite easily have a situation where response_size > host_memory, especially with streaming responses.
There was a problem hiding this comment.
It is not in this level - when persisting a streamed wasi-http response (which I think you have in mind) each chunk read is persisted as a separate oplog entry.
This type is only used in host functions made durable, so basically what they do with it is that they read from the oplog what they otherwise would return when not in replay mode.
It is of course interesting to think of what happens when WASI (and WIT etc) itself will support streams - but to persist functions returning streams will require many changes / improvements anyway.
Resolves #1223
The primary change is introducing https://github.com/golemcloud/golem/pull/1236/files#diff-bcdc1292ac93ac52e1b1b02d1320cae842ccfa169d1b62a97b5aba1abdc44a4eR49 which is going to be moved to Golem's WIT definitions in the next step.