Desktop app: Fix theme switching glitch and improve startup time #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauskin
force-pushed
the
desktop-app-startup-fix
branch
from
f2fdf24 to
ddc6145
Compare
mauskin
changed the title
|
@mauskin Thanks for submitting this! We are pleased to announce you will proceed to the next phase. Please clean up this PR (merging in latest changes from main, re-testing manually, etc.) in preparation for merging. |
mauskin
force-pushed
the
desktop-app-startup-fix
branch
from
9372a0b to
4a06dba
Compare
|
@jdegoes It’s ready. |
mauskin
force-pushed
the
desktop-app-startup-fix
branch
2 times, most recently
from
30a996e to
f3a705a
Compare
mauskin
force-pushed
the
desktop-app-startup-fix
branch
from
f3a705a to
bb4b40c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
When the app loads it displays a blank HTML page, which has white background by default. Also when theme setting in the app is set to “System” changing OS theme doesn’t affect theme in the app.
before.mov
The fix adds a splash screen with Golem logo. The screen respects the system theme. When the app loads it listens to changes to the system theme and–if the app’s theme setting is set to “System”–adapts its theme accordingly.
after.mov
Initial load time is reduced from ~6 seconds to <1 second by removing optimisation of icons (each icon was loaded individually, which multiplied overhead).