New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug? #1

Open

iapcal opened this issue Nov 20, 2019 · 0 comments

iapcal commented Nov 20, 2019 •

edited

Loading

Hi,

There are some code in kmeans cuda fast version might be bug.

k-means/cuda/k-means-fast.cu

Lines 142 to 149 in 3ca19f3

    
           if (index < k) { 
        
             const int count = max(1, counts[index]); 
        
             means_x[index] = new_sum_x[index] / count; 
        
             means_y[index] = new_sum_y[index] / count; 
        
             new_sum_y[index] = 0; 
        
             new_sum_x[index] = 0; 
        
             counts[index] = 0; 
        
           }

I think new_sum_x[index] should be replaced by shared_data at some index.
Btw, shouldn't counts do the parallel reduction on shared memory?

thanks.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment