[#662] XML dialects: Remove the standard dialect based on XML only

goldmansachs · Oct 23, 2024 · 1e252d7 · 1e252d7
1 parent f3eaf6d
commit 1e252d7
Show file tree

Hide file tree

Showing 178 changed files with 55 additions and 56,232 deletions.
diff --git a/dmn-core/src/main/java/com/gs/dmn/dialect/JavaTimePythonStandardDMNDialectDefinition.java b/dmn-core/src/main/java/com/gs/dmn/dialect/JavaTimePythonStandardDMNDialectDefinition.java
@@ -19,7 +19,7 @@
 import com.gs.dmn.feel.synthesis.type.NativeTypeFactory;
 import com.gs.dmn.feel.synthesis.type.StandardNativeTypeToPythonFactory;
 import com.gs.dmn.log.BuildLogger;
-import com.gs.dmn.runtime.DefaultDMNBaseDecision;
+import com.gs.dmn.runtime.JavaTimeDMNBaseDecision;
 import com.gs.dmn.serialization.TypeDeserializationConfigurer;
 import com.gs.dmn.tck.ast.TestCases;
 import com.gs.dmn.transformation.DMNToNativeTransformer;
@@ -66,7 +66,7 @@ public FEELLib<Number, LocalDate, TemporalAccessor, TemporalAccessor, TemporalAm
 
     @Override
     public String getDecisionBaseClass() {
-        return qualifiedName(DefaultDMNBaseDecision.class);
+        return qualifiedName(JavaTimeDMNBaseDecision.class).replace("JavaTime", "Default");
     }
 
     protected String qualifiedName(Class<?> cls) {

diff --git a/dmn-core/src/main/java/com/gs/dmn/dialect/StandardDMNDialectDefinition.java b/dmn-core/src/main/java/com/gs/dmn/dialect/StandardDMNDialectDefinition.java
diff --git a/dmn-core/src/main/java/com/gs/dmn/feel/synthesis/type/StandardNativeTypeFactory.java b/dmn-core/src/main/java/com/gs/dmn/feel/synthesis/type/StandardNativeTypeFactory.java
diff --git a/dmn-core/src/main/java/com/gs/dmn/runtime/interpreter/TypeChecker.java b/dmn-core/src/main/java/com/gs/dmn/runtime/interpreter/TypeChecker.java
@@ -34,7 +34,6 @@
 import com.gs.dmn.transformation.basic.BasicDMNToNativeTransformer;
 
 import javax.xml.datatype.Duration;
-import javax.xml.datatype.XMLGregorianCalendar;
 import javax.xml.namespace.QName;
 import java.time.*;
 import java.time.temporal.TemporalAmount;
@@ -145,15 +144,15 @@ private static boolean isDuration(Object value) {
     }
 
     private static boolean isDateTime(Object value) {
-        return value instanceof XMLGregorianCalendar || value instanceof LocalDateTime || value instanceof OffsetDateTime || value instanceof ZonedDateTime;
+        return value instanceof LocalDateTime || value instanceof OffsetDateTime || value instanceof ZonedDateTime;
     }
 
     private static boolean isTime(Object value) {
-        return value instanceof XMLGregorianCalendar || value instanceof OffsetTime || value instanceof LocalTime;
+        return value instanceof OffsetTime || value instanceof LocalTime;
     }
 
     private static boolean isDate(Object value) {
-        return value instanceof XMLGregorianCalendar || value instanceof LocalDate;
+        return value instanceof LocalDate;
     }
 
     private static boolean isComparable(Object value) {

diff --git a/dmn-core/src/test/java/com/gs/dmn/dialect/StandardDMNDialectDefinitionTest.java b/dmn-core/src/test/java/com/gs/dmn/dialect/StandardDMNDialectDefinitionTest.java
diff --git a/dmn-core/src/test/java/com/gs/dmn/feel/DefaultStandardFEELProcessorTest.java b/dmn-core/src/test/java/com/gs/dmn/feel/DefaultStandardFEELProcessorTest.java